New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711330 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

When the volume popup is shown system menu does not open

Project Member Reported by moh...@chromium.org, Apr 13 2017

Issue description

Chrome Version: 59.0.3071.0 dev

What steps will reproduce the problem?
(1) Change the volume so that the volume popup is shown;
(2) Click or tap on the status tray to open system menu.

What is the expected result?
The volume popup should go away and the system menu should show up.

What happens instead?
The volume popup goes away, but the system menu is not shown. In case of mouse click, the ripple is also not going away!


Notes:
* This also happens when Caps Lock popup is shown (and I guess any other system menu popup).
* This is a regression. Works properly in 56.0.2924.110 stable.
 

Comment 1 by moh...@chromium.org, Apr 13 2017

Also, works properly in 57.0.2987.137 stable.
Labels: M-59
Owner: minch@chromium.org
Status: Assigned (was: Untriaged)
minch@, can you please take a look?

Comment 3 by minch@chromium.org, Apr 17 2017

Status: Started (was: Assigned)
Labels: ReleaseBlock-Stable
Marking as RBS since this can cause a crash. A fix should be merged back into M-59.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/444e30cbb5d2bc60ea021b2405a6cfeea17ca14c

commit 444e30cbb5d2bc60ea021b2405a6cfeea17ca14c
Author: minch <minch@chromium.org>
Date: Wed Apr 19 23:05:00 2017

Open system menu when click the status tray with volume popup opened.

Should open the system menu with one click of the status tray when a
popup detailed view is visible. This is a regression issue related to
https://codereview.chromium.org/2784163003/

BUG= 711330 

Review-Url: https://codereview.chromium.org/2818183002
Cr-Commit-Position: refs/heads/master@{#465801}

[modify] https://crrev.com/444e30cbb5d2bc60ea021b2405a6cfeea17ca14c/ash/system/tray/system_tray.cc
[modify] https://crrev.com/444e30cbb5d2bc60ea021b2405a6cfeea17ca14c/ash/system/tray/system_tray.h

Comment 6 by minch@chromium.org, Apr 20 2017

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Please leave this as Started until it has been merged back to M-59.
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-59; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-59 label, otherwise remove Merge-TBD label. Thanks.

Comment 9 by minch@chromium.org, Apr 20 2017

Status: Started (was: Fixed)
minch@, have you had a chance to verify this on the latest canary? Once verified you should change the Merge-TBD label to Merge-Request-59.

Comment 11 by minch@chromium.org, Apr 27 2017

Labels: -Merge-TBD Merge-Request-59
Project Member

Comment 12 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 28 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3062212915d785dc84b5a695f05e131f95fda280

commit 3062212915d785dc84b5a695f05e131f95fda280
Author: Sarah Hu <xiaoyinh@chromium.org>
Date: Fri Apr 28 01:26:20 2017

[Merge to M59]Open system menu when click the status tray with volume popup opened.

Merge to M59 3071 on behalf of minch@.

Should open the system menu with one click of the status tray when a
popup detailed view is visible. This is a regression issue related to
https://codereview.chromium.org/2784163003/

BUG= 711330 
TBR=tdanderson@chromium.org, xiaoyinh@chromium.org

Review-Url: https://codereview.chromium.org/2818183002
Cr-Commit-Position: refs/heads/master@{#465801}
(cherry picked from commit 444e30cbb5d2bc60ea021b2405a6cfeea17ca14c)

Review-Url: https://codereview.chromium.org/2848783002 .
Cr-Commit-Position: refs/branch-heads/3071@{#279}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/3062212915d785dc84b5a695f05e131f95fda280/ash/system/tray/system_tray.cc
[modify] https://crrev.com/3062212915d785dc84b5a695f05e131f95fda280/ash/system/tray/system_tray.h

Comment 14 by minch@chromium.org, Apr 28 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
ChromeOS 9460.30.0 / 59.0.3071.41

Sign in to add a comment