third_party/WebKit/PRESUBMIT.py failed when "ASSERT" replaced to "DCHECK". |
||
Issue descriptioncan't pass presumit when "ASSERT" replaced to "DCHECK". What steps will reproduce the problem? (1) replace ASSERT to DCHECK in third_party/WebKit/Source/platform/heap/ThreadState.cpp:720. (2) git add third_party/WebKit/Source/platform/heap/ThreadState.cpp (3) git commit (4) git cl upload What is the expected result? It should pass presumit. What happens instead? that CL can't pass presumit. check-webkit-style failed third_party/WebKit/Source/platform/heap/ThreadState.cpp:720: A conditional or loop body must use braces if the statement is more than one line long. [whitespace/braces] [4]
,
Oct 18 2017
Can you still reproduce this issue? It looks like you managed to land your change in https://codereview.chromium.org/2816033003
,
Dec 13 2017
i uploaded it using skip presumit. it was too old. i think do not need to care it. |
||
►
Sign in to add a comment |
||
Comment 1 by hs1217....@samsung.com
, Apr 13 2017