repo upload hooks are incorrect in src/third_party/chromiumos-overlay/chromeos/config |
|||||
Issue description
The repo upload hooks in src/third_party/chromiumos-overlay/chromeos/config are telling me that I need to use spaces instead of tabs at the front of source lines in my CL. This is wrong; we are supposed to use tabs, not spaces.
$ repo upload .
... A new repo command ( 1.23) is available.
... You should upgrade soon:
cp /usr/local/google2/cmtice/chromiumos.new/.repo/repo/repo /usr/local/google/home/cmtice/bin/repo
Run hook scripts from https://chrome-internal.googlesource.com/chromeos/manifest-internal.git (yes/always/NO)? yes
Errors in PROJECT *chromiumos/overlays/chromiumos-overlay*!
COMMIT 3dec23aa:
Description:
>Add 'use x86' to valgrind's filter_clang_syntax.
>
>BUG=None
>TEST=Successfully emerged valgrind for all 4 architectures.
>
>Change-Id: I61e52cee40ed21ad752741bff3e90e66c54a4a4b
>
>
Errors:
* Found a tab character in:
* /usr/local/google2/cmtice/chromiumos.new/src/third_party/chromiumos-overlay/chromeos/config/env/dev-util/valgrind, line 7
* /usr/local/google2/cmtice/chromiumos.new/src/third_party/chromiumos-overlay/chromeos/config/env/dev-util/valgrind, line 8
* /usr/local/google2/cmtice/chromiumos.new/src/third_party/chromiumos-overlay/chromeos/config/env/dev-util/valgrind, line 9
Preupload failed due to errors in project(s). HINTS:
- To disable some source style checks, and for other hints, see <checkout_dir>/src/repohooks/README
- To upload only current project, run 'repo upload .'
,
Apr 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/551cf3e6a802cef988dc40887c1e32d013371cae commit 551cf3e6a802cef988dc40887c1e32d013371cae Author: Mike Frysinger <vapier@chromium.org> Date: Sun Apr 16 02:30:20 2017 PRESUBMIT.cfg: disable tab checks Since ebuilds/eclasses and their supplemental files use tabs, disable the tab checks. BUG= chromium:711327 TEST=uploading a file in chromeos/config/env/ no longer fails Change-Id: I95439fb2cd774440f5668e0df1f574cdec8faf2b Reviewed-on: https://chromium-review.googlesource.com/477870 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/551cf3e6a802cef988dc40887c1e32d013371cae/PRESUBMIT.cfg
,
Apr 16 2017
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by cmt...@chromium.org
, Apr 13 2017