New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711318 link

Starred by 1 user
Status: Fixed
Owner:
█ servolk@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression

Blocking:
issue 697171



Sign in to add a comment

VideoRendererImplTest.DestroyWhileInitializing fails on msan

Project Member Reported by thakis@chromium.org, Apr 13 2017 
This regressed while the bot moved to the main waterfall (so we don't have history), but media_unittests was green two days ago.

Red here: https://build.chromium.org/p/chromium.memory/builders/Linux%20MSan%20Tests/builds/0

Links to https://chromium-swarm.appspot.com/task?id=357e37f358fe8b10&refresh=10&show_raw=1 which says:

[ RUN      ] VideoRendererImplTest.DestroyWhileInitializing
==25382==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x235b2db in media::DecoderSelector<(media::DemuxerStream::Type)2>::DecoderInitDone(bool) media/filters/decoder_selector.cc:217:7
    #1 0xb8a20a in Run base/callback.h:80:12
    #2 0xb8a20a in gmock_PerformImpl<const media::VideoDecoderConfig &, bool, media::CdmContext *, const base::Callback<void (bool), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &, const base::Callback<void (const scoped_refptr<media::VideoFrame> &), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &, testing::internal::ExcessiveArg, testing::internal::ExcessiveArg, testing::internal::ExcessiveArg, testing::internal::ExcessiveArg, testing::internal::ExcessiveArg> media/base/gmock_callback_support.h:70:0
    #3 0xb8a20a in Perform<const media::VideoDecoderConfig &, bool, media::CdmContext *, const base::Callback<void (bool), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &, const base::Callback<void (const scoped_refptr<media::VideoFrame> &), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &> testing/gmock/include/gmock/gmock-generated-actions.h:557:0
    #4 0xb8a20a in media::RunCallbackActionP<3, bool>::gmock_Impl<void (media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)>::Perform(std::__1::tuple<media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&> const&) media/base/gmock_callback_support.h:67:0
    #5 0xfe1325 in Perform testing/gmock/include/gmock/gmock-actions.h:395:19
    #6 0xfe1325 in testing::internal::DoBothAction<testing::SaveArgActionP<4, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>*>, media::RunCallbackActionP<3, bool> >::Impl<void (media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)>::Perform(std::__1::tuple<media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&> const&) testing/gmock/include/gmock/gmock-actions.h:998:0
    #7 0x4428f01 in Perform testing/gmock/include/gmock/gmock-actions.h:395:19
    #8 0x4428f01 in PerformAction<void (const media::VideoDecoderConfig &, bool, media::CdmContext *, const base::Callback<void (bool), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &, const base::Callback<void (const scoped_refptr<media::VideoFrame> &), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &)> testing/gmock/include/gmock/gmock-spec-builders.h:1443:0
    #9 0x4428f01 in testing::internal::FunctionMockerBase<void (media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)>::UntypedPerformAction(void const*, void const*) const testing/gmock/include/gmock/gmock-spec-builders.h:1542:0
    #10 0x4103e18 in testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith(void const*) testing/gmock/src/gmock-spec-builders.cc:411:15
    #11 0xb80465 in InvokeWith testing/gmock/include/gmock/gmock-spec-builders.h:1585:40
    #12 0xb80465 in Invoke testing/gmock/include/gmock/gmock-generated-function-mockers.h:189:0
    #13 0xb80465 in media::MockVideoDecoder::Initialize(media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/base/mock_filters.h:187:0
    #14 0x2359b6d in media::DecoderSelector<(media::DemuxerStream::Type)2>::InitializeDecoder() media/filters/decoder_selector.cc:204:12
    #15 0x23587f9 in media::DecoderSelector<(media::DemuxerStream::Type)2>::SelectDecoder(media::DecoderStreamTraits<(media::DemuxerStream::Type)2>*, media::DemuxerStream*, media::CdmContext*, base::Callback<void (std::__1::unique_ptr<media::VideoDecoder, std::__1::default_delete<media::VideoDecoder> >, std::__1::unique_ptr<media::DecryptingDemuxerStream, std::__1::default_delete<media::DecryptingDemuxerStream> >), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/filters/decoder_selector.cc:112:3
    #16 0x2362375 in media::DecoderStream<(media::DemuxerStream::Type)2>::SelectDecoder() media/filters/decoder_stream.cc:260:22
    #17 0x24d1912 in media::VideoRendererImpl::Initialize(media::DemuxerStream*, media::CdmContext*, media::RendererClient*, base::Callback<bool (std::__1::vector<base::TimeDelta, std::__1::allocator<base::TimeDelta> > const&, std::__1::vector<base::TimeTicks, std::__1::allocator<base::TimeTicks> >*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/renderers/video_renderer_impl.cc:181:24
    #18 0xf9249b in media::VideoRendererImplTest::CallInitialize(media::MockDemuxerStream*, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, bool, bool) media/renderers/video_renderer_impl_unittest.cc:134:16
    #19 0xf91f62 in media::VideoRendererImplTest_DestroyWhileInitializing_Test::TestBody() media/renderers/video_renderer_impl_unittest.cc:564:3
    #20 0x41396dc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #21 0x41396dc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0
    #22 0x413c44b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #23 0x413d9e9 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #24 0x415d58d in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #25 0x415c41e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #26 0x415c41e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
    #27 0x41996b0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #28 0x41996b0 in base::TestSuite::Run() base/test/test_suite.cc:271:0
    #29 0x419df0c in Run base/callback.h:80:12
    #30 0x419df0c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0
    #31 0x419d736 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #32 0x1ceb2e7 in main media/test/run_all_unittests.cc:66:10
    #33 0x7f5c692b3f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0
    #34 0x51ea9b in _start ??:0:0

  Uninitialized value was stored to memory at
    #0 0xb8a225 in media::RunCallbackActionP<3, bool>::gmock_Impl<void (media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)>::Perform(std::__1::tuple<media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&> const&) media/base/gmock_callback_support.h:0:1
    #1 0xfe1325 in Perform testing/gmock/include/gmock/gmock-actions.h:395:19
    #2 0xfe1325 in testing::internal::DoBothAction<testing::SaveArgActionP<4, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>*>, media::RunCallbackActionP<3, bool> >::Impl<void (media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)>::Perform(std::__1::tuple<media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&> const&) testing/gmock/include/gmock/gmock-actions.h:998:0
    #3 0x4428f01 in Perform testing/gmock/include/gmock/gmock-actions.h:395:19
    #4 0x4428f01 in PerformAction<void (const media::VideoDecoderConfig &, bool, media::CdmContext *, const base::Callback<void (bool), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &, const base::Callback<void (const scoped_refptr<media::VideoFrame> &), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &)> testing/gmock/include/gmock/gmock-spec-builders.h:1443:0
    #5 0x4428f01 in testing::internal::FunctionMockerBase<void (media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&)>::UntypedPerformAction(void const*, void const*) const testing/gmock/include/gmock/gmock-spec-builders.h:1542:0
    #6 0x4103e18 in testing::internal::UntypedFunctionMockerBase::UntypedInvokeWith(void const*) testing/gmock/src/gmock-spec-builders.cc:411:15
    #7 0xb80465 in InvokeWith testing/gmock/include/gmock/gmock-spec-builders.h:1585:40
    #8 0xb80465 in Invoke testing/gmock/include/gmock/gmock-generated-function-mockers.h:189:0
    #9 0xb80465 in media::MockVideoDecoder::Initialize(media::VideoDecoderConfig const&, bool, media::CdmContext*, base::Callback<void (bool), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/base/mock_filters.h:187:0
    #10 0x2359b6d in media::DecoderSelector<(media::DemuxerStream::Type)2>::InitializeDecoder() media/filters/decoder_selector.cc:204:12
    #11 0x23587f9 in media::DecoderSelector<(media::DemuxerStream::Type)2>::SelectDecoder(media::DecoderStreamTraits<(media::DemuxerStream::Type)2>*, media::DemuxerStream*, media::CdmContext*, base::Callback<void (std::__1::unique_ptr<media::VideoDecoder, std::__1::default_delete<media::VideoDecoder> >, std::__1::unique_ptr<media::DecryptingDemuxerStream, std::__1::default_delete<media::DecryptingDemuxerStream> >), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (scoped_refptr<media::VideoFrame> const&), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/filters/decoder_selector.cc:112:3
    #12 0x2362375 in media::DecoderStream<(media::DemuxerStream::Type)2>::SelectDecoder() media/filters/decoder_stream.cc:260:22
    #13 0x24d1912 in media::VideoRendererImpl::Initialize(media::DemuxerStream*, media::CdmContext*, media::RendererClient*, base::Callback<bool (std::__1::vector<base::TimeDelta, std::__1::allocator<base::TimeDelta> > const&, std::__1::vector<base::TimeTicks, std::__1::allocator<base::TimeTicks> >*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/renderers/video_renderer_impl.cc:181:24
    #14 0xf9249b in media::VideoRendererImplTest::CallInitialize(media::MockDemuxerStream*, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, bool, bool) media/renderers/video_renderer_impl_unittest.cc:134:16
    #15 0xf91f62 in media::VideoRendererImplTest_DestroyWhileInitializing_Test::TestBody() media/renderers/video_renderer_impl_unittest.cc:564:3
    #16 0x41396dc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #17 0x41396dc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0
    #18 0x413c44b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #19 0x413d9e9 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #20 0x415d58d in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #21 0x415c41e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #22 0x415c41e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
    #23 0x41996b0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #24 0x41996b0 in base::TestSuite::Run() base/test/test_suite.cc:271:0
    #25 0x419df0c in Run base/callback.h:80:12
    #26 0x419df0c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0
    #27 0x419d736 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #28 0x1ceb2e7 in main media/test/run_all_unittests.cc:66:10

  Uninitialized value was stored to memory at
    #0 0xfde7b4 in gmock_Impl media/base/gmock_callback_support.h:67:1
    #1 0xfde7b4 in operator Action<void (const media::VideoDecoderConfig &, bool, media::CdmContext *, const base::Callback<void (bool), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &, const base::Callback<void (const scoped_refptr<media::VideoFrame> &), base::internal::CopyMode::Copyable, base::internal::RepeatMode::Repeating> &)> media/base/gmock_callback_support.h:67:0
    #2 0xfde7b4 in _ZNK7testing8internal12DoBothActionINS_14SaveArgActionPILi4EPN4base8CallbackIFvRK13scoped_refptrIN5media10VideoFrameEEELNS3_8internal8CopyModeE1ELNSC_10RepeatModeE1EEEEENS6_18RunCallbackActionPILi3EbEEEcvNS_6ActionIT_EEIFvRKNS6_18VideoDecoderConfigEbPNS6_10CdmContextERKNS4_IFvbELSD_1ELSE_1EEERKSF_EEEv testing/gmock/include/gmock/gmock-actions.h:981:0
    #3 0xfdbde9 in media::VideoRendererImplTest::CreateVideoDecodersForTest() media/renderers/video_renderer_impl_unittest.cc:61:19
    #4 0xfddfd5 in Invoke<media::VideoRendererImplTest *> base/bind_internal.h:214:12
    #5 0xfddfd5 in MakeItSo<ScopedVector<media::VideoDecoder> (media::VideoRendererImplTest::*const &)(), media::VideoRendererImplTest *> base/bind_internal.h:285:0
    #6 0xfddfd5 in RunImpl<ScopedVector<media::VideoDecoder> (media::VideoRendererImplTest::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<media::VideoRendererImplTest> > &, 0> base/bind_internal.h:361:0
    #7 0xfddfd5 in base::internal::Invoker<base::internal::BindState<ScopedVector<media::VideoDecoder> (media::VideoRendererImplTest::*)(), base::internal::UnretainedWrapper<media::VideoRendererImplTest> >, ScopedVector<media::VideoDecoder> ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0
    #8 0x24d089d in Run base/callback.h:80:12
    #9 0x24d089d in media::VideoRendererImpl::Initialize(media::DemuxerStream*, media::CdmContext*, media::RendererClient*, base::Callback<bool (std::__1::vector<base::TimeDelta, std::__1::allocator<base::TimeDelta> > const&, std::__1::vector<base::TimeTicks, std::__1::allocator<base::TimeTicks> >*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/renderers/video_renderer_impl.cc:153:0
    #10 0xf9249b in media::VideoRendererImplTest::CallInitialize(media::MockDemuxerStream*, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, bool, bool) media/renderers/video_renderer_impl_unittest.cc:134:16
    #11 0xf91f62 in media::VideoRendererImplTest_DestroyWhileInitializing_Test::TestBody() media/renderers/video_renderer_impl_unittest.cc:564:3
    #12 0x41396dc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #13 0x41396dc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0
    #14 0x413c44b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #15 0x413d9e9 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #16 0x415d58d in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #17 0x415c41e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #18 0x415c41e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
    #19 0x41996b0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #20 0x41996b0 in base::TestSuite::Run() base/test/test_suite.cc:271:0
    #21 0x419df0c in Run base/callback.h:80:12
    #22 0x419df0c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0
    #23 0x419d736 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #24 0x1ceb2e7 in main media/test/run_all_unittests.cc:66:10
    #25 0x7f5c692b3f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0

  Uninitialized value was stored to memory at
    #0 0xfdd32a in media::VideoRendererImplTest::CreateVideoDecodersForTest() media/renderers/video_renderer_impl_unittest.cc:61:19
    #1 0xfddfd5 in Invoke<media::VideoRendererImplTest *> base/bind_internal.h:214:12
    #2 0xfddfd5 in MakeItSo<ScopedVector<media::VideoDecoder> (media::VideoRendererImplTest::*const &)(), media::VideoRendererImplTest *> base/bind_internal.h:285:0
    #3 0xfddfd5 in RunImpl<ScopedVector<media::VideoDecoder> (media::VideoRendererImplTest::*const &)(), const std::__1::tuple<base::internal::UnretainedWrapper<media::VideoRendererImplTest> > &, 0> base/bind_internal.h:361:0
    #4 0xfddfd5 in base::internal::Invoker<base::internal::BindState<ScopedVector<media::VideoDecoder> (media::VideoRendererImplTest::*)(), base::internal::UnretainedWrapper<media::VideoRendererImplTest> >, ScopedVector<media::VideoDecoder> ()>::Run(base::internal::BindStateBase*) base/bind_internal.h:339:0
    #5 0x24d089d in Run base/callback.h:80:12
    #6 0x24d089d in media::VideoRendererImpl::Initialize(media::DemuxerStream*, media::CdmContext*, media::RendererClient*, base::Callback<bool (std::__1::vector<base::TimeDelta, std::__1::allocator<base::TimeDelta> > const&, std::__1::vector<base::TimeTicks, std::__1::allocator<base::TimeTicks> >*), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) media/renderers/video_renderer_impl.cc:153:0
    #7 0xf9249b in media::VideoRendererImplTest::CallInitialize(media::MockDemuxerStream*, base::Callback<void (media::PipelineStatus), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, bool, bool) media/renderers/video_renderer_impl_unittest.cc:134:16
    #8 0xf91f62 in media::VideoRendererImplTest_DestroyWhileInitializing_Test::TestBody() media/renderers/video_renderer_impl_unittest.cc:564:3
    #9 0x41396dc in HandleExceptionsInMethodIfSupported<testing::Test, void> testing/gtest/src/gtest.cc:2458:12
    #10 0x41396dc in testing::Test::Run() testing/gtest/src/gtest.cc:2474:0
    #11 0x413c44b in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2656:11
    #12 0x413d9e9 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #13 0x415d58d in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #14 0x415c41e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #15 0x415c41e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
    #16 0x41996b0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #17 0x41996b0 in base::TestSuite::Run() base/test/test_suite.cc:271:0
    #18 0x419df0c in Run base/callback.h:80:12
    #19 0x419df0c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0
    #20 0x419d736 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #21 0x1ceb2e7 in main media/test/run_all_unittests.cc:66:10
    #22 0x7f5c692b3f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0

  Uninitialized value was created by a heap allocation
    #0 0x58f249 in operator new(unsigned long) ??:0:0
    #1 0xfe3a83 in testing::internal::TestFactoryImpl<media::VideoRendererImplTest_DestroyWhileInitializing_Test>::CreateTest() testing/gtest/include/gtest/internal/gtest-internal.h:484:39
    #2 0x413c24f in HandleExceptionsInMethodIfSupported<testing::internal::TestFactoryBase, testing::Test *> testing/gtest/src/gtest.cc:2458:12
    #3 0x413c24f in testing::TestInfo::Run() testing/gtest/src/gtest.cc:2647:0
    #4 0x413d9e9 in testing::TestCase::Run() testing/gtest/src/gtest.cc:2774:28
    #5 0x415d58d in testing::internal::UnitTestImpl::RunAllTests() testing/gtest/src/gtest.cc:4647:43
    #6 0x415c41e in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> testing/gtest/src/gtest.cc:2458:12
    #7 0x415c41e in testing::UnitTest::Run() testing/gtest/src/gtest.cc:4255:0
    #8 0x41996b0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #9 0x41996b0 in base::TestSuite::Run() base/test/test_suite.cc:271:0
    #10 0x419df0c in Run base/callback.h:80:12
    #11 0x419df0c in base::(anonymous namespace)::LaunchUnitTestsInternal(base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&, int, int, bool, base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:211:0
    #12 0x419d736 in base::LaunchUnitTests(int, char**, base::Callback<int (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1> const&) base/test/launcher/unit_test_launcher.cc:453:10
    #13 0x1ceb2e7 in main media/test/run_all_unittests.cc:66:10
    #14 0x7f5c692b3f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value (/b/s/w/ir/out/Release/media_unittests+0x235b2db)
Exiting
[3008/3008] VideoRendererImplTest.DestroyWhileInitializing (CRASHED)

Very likely due to https://codereview.chromium.org/2684103005

Comment 1 by dalecur...@chromium.org, Apr 13 2017

Components: Internals>Media

Comment 2 by servolk@chromium.org, Apr 13 2017 

Hmm, I guess this is due to VideoRendererImplTest::expect_init_success_ being uninitialized. I'll try to understand how that happens.

Comment 3 by servolk@chromium.org, Apr 13 2017

Status: Started (was: Assigned)

Comment 4 by servolk@chromium.org, Apr 13 2017 

Yep, I think I understand the problem. The VideoRendererImplTest.DestroyWhileInitializing is the only test that uses a special decoder initialization path (VideoRendererImplTest::CallInitialize) where CreateVideoDecodersForTest gets invoked before InitializeRenderer, which initializes expect_init_success_. We just need to initialize the expect_init_success_ in the constructor to fix this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cefc60264ab620406f71fdb27e817b406465e94

commit 7cefc60264ab620406f71fdb27e817b406465e94
Author: thakis <thakis@chromium.org>
Date: Thu Apr 13 17:56:05 2017

Update bug numbers of disabled MSan tests.

https://codereview.chromium.org/2817443004/ used a tracking bug as
TODO for various tests failing on MSan. Used one targeted bug per
failing test instead.

BUG= 697171 , 711318 , 709341 ,710486
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=danakj,dalecurtis

Review-Url: https://codereview.chromium.org/2818763002
Cr-Commit-Position: refs/heads/master@{#464463}

[modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/cc/tiles/gpu_image_decode_cache_unittest.cc
[modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/7cefc60264ab620406f71fdb27e817b406465e94/media/renderers/video_renderer_impl_unittest.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/786d0251c33344501eed4dc016e84416bad11fe1

commit 786d0251c33344501eed4dc016e84416bad11fe1
Author: servolk <servolk@chromium.org>
Date: Thu Apr 13 19:16:34 2017

Fix uninitialized variable in VideoRendererImplTest

The |expect_init_success_| variable is typically initialized in
InitializeRenderer, but the DestroyWhileInitializing test case invokes
CallInitialize directly, which will invoke CreateVideoDecodersForTest
before the InitializeRenderer runs, so we need to ensure
expect_init_success_ is always initialized.

BUG= 711318 

Review-Url: https://codereview.chromium.org/2808763012
Cr-Commit-Position: refs/heads/master@{#464495}

[modify] https://crrev.com/786d0251c33344501eed4dc016e84416bad11fe1/media/renderers/video_renderer_impl_unittest.cc

Comment 7 by servolk@chromium.org, Apr 13 2017

Status: Fixed (was: Started)

Comment 8 by dalecur...@chromium.org, Apr 13 2017 

You need to restore the tests?

Comment 9 by servolk@chromium.org, Apr 13 2017 

I actually did that in subsequent patchsets of https://codereview.chromium.org/2808763012

Comment 10 by dalecur...@chromium.org, Apr 13 2017 

Ah, thanks!
►

Sign in to add a comment