Happy Birthday Doodle is not displayed in NewTabPage |
|||||||||||
Issue descriptionApp Version: 58.0.3029.66 beta iOS Version: 10.3.2, 10.3 Device: iPhone7, iPhone6 plus, iPad URL NA Precondition: Goto https://aboutme.google.com with any testaccount, Edit Birth day to today Steps to reproduce: 1. Launch Google Chrome 2. Sign in with test account for which Birthday is changed to today 3. Open a new tab Observed results: Happy Birthday doodle should be displayed Note: Birthday Doodle is displayed on Mac Chrome NTP, www.google.com if the account signed in. Expected results: Happy Birthday doodle not displayed. Google Logo is only displayed Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Not Tested Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA Bug reproducible on current stable build (App Version, iOS Version): M57 Yes Bug reproducible on the current beta channel build (App Version, iOS Version): M58 Yes
,
Apr 13 2017
Yes, It atleast worked until M44 :) I was going through an old bug http://crbug/490718. Watch the video from the other bug.
,
Apr 13 2017
Hm. Is that when iOS Chrome switched from UIWebView to WKWebView?
,
Apr 13 2017
M48 is when Chrome switched to WKWebView.
,
Apr 13 2017
So, is it possible that birthday doodles broke at that point? With WKWV, the doodle request does not contain Google signin cookies anymore, so no birthday doodles. Of course, it might have broken even before that, but I guess that doesn't really matter anymore.
,
Apr 13 2017
,
Apr 13 2017
treib@ would you like to take this on as part of the new doodle code?
,
Apr 13 2017
The new Doodle code will probably support this eventually, but not at first. There will also be server-side changes required to support OAuth2 rather than cookies. Shouldn't be too bad though.
,
Apr 17 2017
It's not worth doing this work for the current doodle front and backend. Flipping to treib@ for future work. Not critical.
,
Apr 25 2017
,
Oct 13 2017
Throwing back into the pool since I don't have concrete plans to work on this.
,
Oct 15
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 15
I think this is still relevant, though really a low-prio feature request rather than a bug.
,
Oct 15
+Kyle FYI FWIW, I cannot set a birthday on a pre-existing account via https://aboutme.google.com.
,
Oct 15
You can edit it at https://myaccount.google.com/birthday Just to be clear, the issue here is making the Doodle request authenticated, then the API should automatically do the right thing. Currently we use cookies for authentication, which works on Android and desktop, but not on iOS because there Chrome doesn't actually have access to the content-area cookies. The solution is probably migrating this all to OAuth2 instead of cookies, which I never got around to.
,
Oct 15
Thanks!
,
Oct 16
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by treib@chromium.org
, Apr 13 2017