New issue
Advanced search Search tips

Issue 711302 link

Starred by 2 users
Status: Archived
Owner: ----
Closed: Sep 27
Cc:
kkaluri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Can't use generated buildflag headers in //ipc

Reported by davi...@inf.u-szeged.hu, Apr 13 2017 
UserAgent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0

Steps to reproduce the problem:
I tried to make several headers in the ipc module dependent on a generated buildflag header here:
https://codereview.chromium.org/2770653002/

... but it caused a build flake, so it was reverted out here:
https://codereview.chromium.org/2768403002/

The builder machine tried to include the buildflag header before generating it. It seemed the private deps of other modules were causing the flake, so there was a try to fix these:
https://codereview.chromium.org/2767193005

After that I have tried to reland the patch:
https://codereview.chromium.org/2777983005/

... but it's still causing flaky build with the same reason:
https://codereview.chromium.org/2776393003/

What is the expected behavior?

What went wrong?
Could it be a bug in GN?

Did this work before? N/A 

Chrome version:   Channel: dev
OS Version: 
Flash Version:

Comment 1 by pfeldman@chromium.org, Apr 13 2017

Components: -Platform>DevTools
Project Member

Comment 2 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c2d1c61befedf006810b4e9d663d6dfae602eeb

commit 3c2d1c61befedf006810b4e9d663d6dfae602eeb
Author: davidsz <davidsz@inf.u-szeged.hu>
Date: Thu May 04 01:26:52 2017

Make extensions/browser/api/* sources to publicly depend on //ipc

Several //ipc headers will depend on a generated buildflag header and
we have to guarantee the existence of this header before the build of
these source sets.

BUG= 711302 

Review-Url: https://codereview.chromium.org/2852273002
Cr-Commit-Position: refs/heads/master@{#469232}

[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/AUTHORS
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/activity_log/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/alarms/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/app_current_window_internal/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/app_runtime/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/app_window/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/audio/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/bluetooth/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/bluetooth_low_energy/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/bluetooth_socket/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/cast_channel/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/clipboard/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/declarative/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/declarative_content/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/declarative_webrequest/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/diagnostics/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/display_source/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/dns/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/document_scan/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/file_handlers/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/hid/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/idle/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/management/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/messaging/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/metrics_private/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/mime_handler_private/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/networking_config/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/networking_private/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/power/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/printer_provider/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/printer_provider_internal/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/runtime/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/serial/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/socket/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/sockets_tcp/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/sockets_tcp_server/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/sockets_udp/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/storage/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/system_cpu/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/system_display/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/system_info/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/system_memory/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/system_network/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/system_storage/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/test/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/usb/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/virtual_keyboard/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/virtual_keyboard_private/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/vpn_provider/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/web_request/BUILD.gn
[modify] https://crrev.com/3c2d1c61befedf006810b4e9d663d6dfae602eeb/extensions/browser/api/webcam_private/BUILD.gn

Comment 3 by kkaluri@chromium.org, Sep 27 2017

Cc: kkaluri@chromium.org
Components: Platform>Extensions
Labels: Needs-Milestone TE-NeedsTriageHelp
Unable to triage this issue from TE end, hence adding TE-NeedsTriageHelp for further triage
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 27

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
►

Sign in to add a comment