New issue
Advanced search Search tips

Issue 711273 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

MediaStreamVideoTrack::GetSettings returns frame rate of the source, not the track

Project Member Reported by guidou@chromium.org, Apr 13 2017

Issue description

See 
https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_video_track.cc?sq=package:chromium&type=cs&q=MediaStreamVideoTrack::GetSe&l=405

It should return the frame rate of the track, which might be different from the frame rate of the source due to frame-rate adjustment.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017

Comment 2 by guidou@chromium.org, Apr 18 2017

Labels: Merge-Request-59
Status: Fixed (was: Untriaged)
Please tag with applicable OSs.  Thanks!
Project Member

Comment 4 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 5 by guidou@chromium.org, Apr 19 2017

Labels: OS-All
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b249dd212dea164750205c689434d0341a9ad266

commit b249dd212dea164750205c689434d0341a9ad266
Author: Guido Urdaneta <guidou@chromium.org>
Date: Thu Apr 20 08:40:20 2017

Make MediaStreamVideoTrack::GetSettings return the track's frame rate.

It is currently returning the underlying source's native frame rate,
which might be different from the adjusted rate of the track.

BUG= 711273 

Review-Url: https://codereview.chromium.org/2817673004
Cr-Commit-Position: refs/heads/master@{#465257}
(cherry picked from commit 935f9a2b54e4ac084ac81634a4a7afcd5de511bb)

Review-Url: https://codereview.chromium.org/2827263002 .
Cr-Commit-Position: refs/branch-heads/3071@{#78}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_source.cc
[modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_track.cc
[modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_track.h
[modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_track_unittest.cc

Sign in to add a comment