MediaStreamVideoTrack::GetSettings returns frame rate of the source, not the track |
|||||
Issue descriptionSee https://cs.chromium.org/chromium/src/content/renderer/media/media_stream_video_track.cc?sq=package:chromium&type=cs&q=MediaStreamVideoTrack::GetSe&l=405 It should return the frame rate of the track, which might be different from the frame rate of the source due to frame-rate adjustment.
,
Apr 18 2017
,
Apr 18 2017
Please tag with applicable OSs. Thanks!
,
Apr 19 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 19 2017
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b249dd212dea164750205c689434d0341a9ad266 commit b249dd212dea164750205c689434d0341a9ad266 Author: Guido Urdaneta <guidou@chromium.org> Date: Thu Apr 20 08:40:20 2017 Make MediaStreamVideoTrack::GetSettings return the track's frame rate. It is currently returning the underlying source's native frame rate, which might be different from the adjusted rate of the track. BUG= 711273 Review-Url: https://codereview.chromium.org/2817673004 Cr-Commit-Position: refs/heads/master@{#465257} (cherry picked from commit 935f9a2b54e4ac084ac81634a4a7afcd5de511bb) Review-Url: https://codereview.chromium.org/2827263002 . Cr-Commit-Position: refs/branch-heads/3071@{#78} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_source.cc [modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_track.cc [modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_track.h [modify] https://crrev.com/b249dd212dea164750205c689434d0341a9ad266/content/renderer/media/media_stream_video_track_unittest.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Apr 18 2017