New issue
Advanced search Search tips

Issue 711269 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Flaky JS error in setBatteryPercent at oobe/login.js

Project Member Reported by emaxx@chromium.org, Apr 13 2017

Issue description

Chrome Version: ToT
OS: Chrome OS

What steps will reproduce the problem?
(1) Go to Chrome OS login screen.

What happens instead?
Everything seems to work as normal, but the ui.LATEST log sometimes contains an error:
[ERROR:CONSOLE(8544)] "TypeError: Cannot read property 'apply' of undefined
    at Object.api.(anonymous function) [as setBatteryPercent] (chrome://oobe/login.js:415:42)
    at <anonymous>:1:33", source: chrome://oobe/login.js (8544)
 

Comment 1 by xiy...@chromium.org, Apr 13 2017

Cc: -xiy...@chromium.org fukino@chromium.org
Owner: xiy...@chromium.org
Status: Assigned (was: Untriaged)
We might be too aggressive on observing the power status.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f925a21a93ff3fb173fcd9bca9146ad3b002083a

commit f925a21a93ff3fb173fcd9bca9146ad3b002083a
Author: Xiyuan Xia <xiyuan@chromium.org>
Date: Thu Apr 13 18:28:16 2017

Start power observing when migration screen initialized

Migration screen handler ctor is called during OobeUI creation
in browser process and power callback could call JS too early
before the renderer side finishes initialization. Defer the observing
start to Initialize that is called when page js is ready.

BUG= 711269 

Change-Id: I866fd33ca68341fb646f4612a430b5eb1921e6f3
Reviewed-on: https://chromium-review.googlesource.com/477113
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#464476}
[modify] https://crrev.com/f925a21a93ff3fb173fcd9bca9146ad3b002083a/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc

Comment 4 by xiy...@chromium.org, Apr 13 2017

Status: Fixed (was: Assigned)

Comment 5 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 6 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 7 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment