The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6703f4df6ad92a629ea4ac736f6ff26402ef139e

commit 6703f4df6ad92a629ea4ac736f6ff26402ef139e
Author: ricea <ricea@chromium.org>
Date: Wed Apr 19 05:29:15 2017

Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db8c32.

This CL also removes failing test expectations. Issue 626703 and  711529  cover lines
that were removed from TestExpectations.

BUG= 711254 ,626703, 711529 , 684543 

Review-Url: https://codereview.chromium.org/2823563002
Cr-Commit-Position: refs/heads/master@{#465498}

[modify] https://crrev.com/6703f4df6ad92a629ea4ac736f6ff26402ef139e/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https.html
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.js
[modify] https://crrev.com/6703f4df6ad92a629ea4ac736f6ff26402ef139e/third_party/WebKit/Source/core/streams/WritableStream.js

I would like to merge this to the M59 branch as it significantly improves the standard compliance of our WritableStream implementation. There are quite a lot of w3c web-platform-test failures in the version on the M59 branch; with the version on trunk we pass all tests.

Risk is minimal:
* Changes are limited to the WritableStream class.
* We have near-complete test coverage.
* M-59 is the first Chrome release to ship WritableStream, so there are no existing users to break.

I have tested the changes in Canary version 60.0.3076.0.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f703afd1326015ab595fb8e857df55c765f0c9e7

commit f703afd1326015ab595fb8e857df55c765f0c9e7
Author: Adam Rice <ricea@chromium.org>
Date: Thu Apr 20 13:18:46 2017

Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db8c32.

The version of this CL merged to M59 branch 3071 adds failing and time-out test
expectations since the tests on hte branch are now out-of-date with respect to
the implementation. See  http://crbug.com/713664 .

BUG= 711254 , 684543 

Review-Url: https://codereview.chromium.org/2823563002
Cr-Commit-Position: refs/heads/master@{#465498}
(cherry picked from commit 6703f4df6ad92a629ea4ac736f6ff26402ef139e)

Review-Url: https://codereview.chromium.org/2831763003 .
Cr-Commit-Position: refs/branch-heads/3071@{#82}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-backward.sharedworker-expected.txt
[modify] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward-expected.txt
[modify] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.dedicatedworker-expected.txt
[modify] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.serviceworker.https-expected.txt
[modify] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/close-propagation-forward.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/flow-control.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/general-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/general.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/piping/multiple-propagation.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/bad-underlying-sinks.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/reentrant-strategy.sharedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.dedicatedworker-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.serviceworker.https-expected.txt
[add] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/write.sharedworker-expected.txt
[delete] https://crrev.com/17fd10d4ba20794735a1f50066816590e9d9b398/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https-expected.txt
[delete] https://crrev.com/17fd10d4ba20794735a1f50066816590e9d9b398/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https.html
[delete] https://crrev.com/17fd10d4ba20794735a1f50066816590e9d9b398/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.js
[modify] https://crrev.com/f703afd1326015ab595fb8e857df55c765f0c9e7/third_party/WebKit/Source/core/streams/WritableStream.js