New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711190 link

Starred by 1 user
Status: Fixed
Owner:
yigu@chromium.org
Closed: Apr 2017
Cc:
flackr@chromium.org
ajuma@chromium.org
█ jwd@chromium.org
tdres...@chromium.org
bokan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Project Member Reported by jdoerrie@chromium.org, Apr 13 2017 
webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4)

Starting from build #63608 WebKit Android (Nexus4) Builder fails consistently on webkit_unit_tests
NonCompositedMainThreadScrollingReasonRecordTest.NestedScrollersTest:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29

Culprit likely lies in range r464061 ... r464077 (https://test-results.appspot.com/revision_range?start=464061&end=464077), could be r464073.

Log Snippet:

C  123.247s Main  ********************************************************************************
C  123.247s Main  Detailed Logs
C  123.247s Main  ********************************************************************************
C  123.251s Main  [FAIL] NonCompositedMainThreadScrollingReasonRecordTest.NestedScrollersTest:
C  123.251s Main  [ RUN      ] NonCompositedMainThreadScrollingReasonRecordTest.NestedScrollersTest
C  123.251s Main  ../../base/test/histogram_tester.cc:155: Failure
C  123.251s Main  Value of: actual_count
C  123.251s Main    Actual: 0
C  123.251s Main  Expected: expected_count
C  123.251s Main  Which is: 1
C  123.251s Main  Histogram "Renderer4.MainThreadWheelScrollReason" does not have the right number of samples (1) in the expected bucket (17). It has (0).
C  123.251s Main  ../../base/test/histogram_tester.cc:170: Failure
C  123.251s Main  Value of: actual_count
C  123.251s Main    Actual: 2
C  123.251s Main  Expected: expected_count
C  123.251s Main  Which is: 3
C  123.251s Main  Histogram "Renderer4.MainThreadWheelScrollReason" does not have the right total number of samples (3). It has (2).
C  123.251s Main  [  FAILED  ] NonCompositedMainThreadScrollingReasonRecordTest.NestedScrollersTest (31 ms)
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998f8e571bebd0ace499f8fef81f91daffada15f

commit 998f8e571bebd0ace499f8fef81f91daffada15f
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Apr 13 08:10:32 2017

Revert of Move logic of recording main thread scrolling reasons from cc to blink::ScrollManager (patchset #17 id:320001 of https://codereview.chromium.org/2773593005/ )

Reason for revert:
Likely cause of webkit_unit_tests failing on chromium.webkit/WebKit Android (Nexus4).

BUG= 711190 

Original issue's description:
> Move logic of recording main thread scrolling reasons from cc to
> blink::ScrollManager
>
> Due to  crbug.com/701355 , all style related main thread scrolling reasons
> stop being recorded. This patch moves the logic of storing the style
> related reasons to PLSA and move the recording logic to ScrollManager
> because the information on the compositor side is insufficient. The
> disabled test due to the previous bug has been enabled again with minor
> modification.
>
> BUG= 704805 
> TEST=All/NonCompositedMainThreadScrollingReasonTest.*;
> EventHandlerTest.NonCompositedMainThreadScrollingReason*
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Review-Url: https://codereview.chromium.org/2773593005
> Cr-Commit-Position: refs/heads/master@{#464073}
> Committed: https://chromium.googlesource.com/chromium/src/+/76d0929033d6cd3ec36b96d1b4845166e70c9349

TBR=flackr@chromium.org,ajuma@chromium.org,bokan@chromium.org,tdresser@chromium.org,jwd@chromium.org,yigu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 704805 

Review-Url: https://codereview.chromium.org/2816973002
Cr-Commit-Position: refs/heads/master@{#464337}

[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/cc/input/main_thread_scrolling_reason.h
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/frame/FrameView.cpp
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/frame/FrameView.h
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/input/EventHandlerTest.cpp
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/input/ScrollManager.h
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/third_party/WebKit/Source/web/tests/data/two_scrollable_area.html
[modify] https://crrev.com/998f8e571bebd0ace499f8fef81f91daffada15f/ui/events/blink/input_handler_proxy.cc

Comment 2 by jdoerrie@chromium.org, Apr 13 2017

Cc: flackr@chromium.org bokan@chromium.org ajuma@chromium.org tdres...@chromium.org jwd@chromium.org
Components: Blink>Compositing
Labels: -Sheriff-Chromium Pri-2
Owner: yigu@chromium.org
Bot is green again, removing Sheriff label and assigning to original CL author. yigu@, do you mind taking another look at this?

Comment 3 by yigu@chromium.org, Apr 13 2017

Status: Fixed (was: Available)
In the unit test that failed, we had an element that was not scrollable on
Android devices which caused the failure. Making it scrollable fixes the
problem.
►

Sign in to add a comment