New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711183 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Status menu contains yellow rows

Project Member Reported by fbeaufort@chromium.org, Apr 13 2017

Issue description

Chrome Version       : 59.0.3054.0
OS Version: 9413.0.0

As you can see in the photo below, it looks like some rows are tainted yellow on my screen. May we fix that?



 
IMG_20170413_092932.jpg
1.1 MB View Download
Cc: tbuck...@chromium.org bruthig@chromium.org fukino@chromium.org est...@chromium.org
Labels: -Type-Bug -Pri-3 M-59 ReleaseBlock-Stable Pri-1 Type-Bug-Regression
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
fbeaufort@, what channel and device are you seeing this on? FTR I do not see this on the latest minnie Canary 59.0.3068.1.

estade@, bruthig@, fukino@, any ideas here?
fbeaufort@, is there any chance you could send a screen shot instead of a camera picture?  I'd like to know what the actual color is.

You can use <ctrl> + F5 to capture the entire screen or <ctrl> + <alt> + F5 to select a capture region.

Comment 3 by est...@chromium.org, Apr 13 2017

Owner: tdander...@chromium.org
no idea. Someone on cros team should attempt to repro / bisect.
Cc: dhadd...@chromium.org
David, has your team encountered this / anything similar recently?

Comment 5 by dhaddock@google.com, Apr 13 2017

I haven't. What device is this?
I've reproduced on Pixel 2013 with 59.0.3065.0 (Official Build) dev (64-bit).
Using a color picker, I can tell the "yellowish" color is #fefefe.


Comment 7 by est...@chromium.org, Apr 14 2017

Cc: sgabr...@chromium.org
what is the non-yellowish color? is it #ffffff? It would be pretty surprising if fefefe and ffffff were visibly different. Perhaps a hardware issue.

I believe the fefefe is coming from here:
https://cs.chromium.org/chromium/src/ash/system/tray/tray_constants.cc?l=66&gs=cpp%253Aash%253A%253AkBackgroundColor%2540chromium%252F..%252F..%252Fash%252Fsystem%252Ftray%252Ftray_constants.cc%257Cdef&gsn=kBackgroundColor&ct=xref_usages

Should it be white (#fff)? We use pure white for bubble backgrounds, menu backgrounds, etc. (see ui/native_theme/common_theme.cc)
Yes everything should be #FFF

Comment 9 by est...@chromium.org, Apr 14 2017

Owner: est...@chromium.org
Status: Started (was: Assigned)
I'll make the simple fix for now but also later refactor to make it harder to mess up like this in the future.
Any updates?
Waiting for review. Canada has been on holiday.
Re #11 I think I have reviewed both of your CLs related to this bug, please let me know if I have missed something.
yes, now waiting on commit queue
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cabc715051c1f91e095acba28c0503df6c4b55c4

commit cabc715051c1f91e095acba28c0503df6c4b55c4
Author: estade <estade@chromium.org>
Date: Tue Apr 18 20:42:19 2017

Make ChromeOS tray background color white instead of off-white.

Patch is designed as a quick and easy fix that should be easy to merge.
A more comprehensive follow up will come later.

BUG= 711183 

Review-Url: https://codereview.chromium.org/2812223008
Cr-Commit-Position: refs/heads/master@{#465355}

[modify] https://crrev.com/cabc715051c1f91e095acba28c0503df6c4b55c4/ash/system/tray/tray_constants.cc

Labels: Merge-Request-59
Labels: Merge-Approved-59
Project Member

Comment 17 by bugdroid1@chromium.org, Apr 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1df4ea84c961068355e67b1b8075f368a1b7857c

commit 1df4ea84c961068355e67b1b8075f368a1b7857c
Author: Evan Stade <estade@chromium.org>
Date: Wed Apr 19 18:03:28 2017

Make ChromeOS tray background color white instead of off-white.

Patch is designed as a quick and easy fix that should be easy to merge.
A more comprehensive follow up will come later.

BUG= 711183 

Review-Url: https://codereview.chromium.org/2812223008
Cr-Commit-Position: refs/heads/master@{#465355}
(cherry picked from commit cabc715051c1f91e095acba28c0503df6c4b55c4)

Review-Url: https://codereview.chromium.org/2828053002 .
Cr-Commit-Position: refs/branch-heads/3071@{#56}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/1df4ea84c961068355e67b1b8075f368a1b7857c/ash/system/tray/tray_constants.cc

Status: Fixed (was: Started)
Project Member

Comment 19 by sheriffbot@chromium.org, Apr 20 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 20 by sheriffbot@chromium.org, Apr 24 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-59
Project Member

Comment 22 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/097f9cde453ea57eb4aa037f44add782391c5eb9

commit 097f9cde453ea57eb4aa037f44add782391c5eb9
Author: estade <estade@chromium.org>
Date: Tue Apr 25 01:01:27 2017

Introduce a type of View background that stays in sync with its host
View's native theme.

This fixes a few bugs where we weren't using the right native theme,
whether by not updating after the NativeTheme changes or by trying to
access the NativeTheme before the View is added to a hierarchy (which
yields the default NativeTheme --- for most platforms, this didn't
effectively create a bug as there's only one NativeTheme).

Best example is that now the sad tab respects the GTK native theme.

Get rid of Ash's tray_constants::kBackgroundColor in favor of using the
bubble background color from the NativeTheme.

BUG= 711183 , 693282 
TBR=stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2816193002
Cr-Commit-Position: refs/heads/master@{#466847}

[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/audio/volume_view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/tray/system_tray.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/tray/tray_constants.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/tray/tray_constants.h
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/tray_accessibility.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/user/user_card_view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/user/user_view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ash/system/user/user_view.h
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/chrome/browser/ui/views/sad_tab_view.h
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/message_center/views/message_bubble_base.h
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/views/background.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/views/background.h
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/views/bubble/tray_bubble_view.h
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/views/view.cc
[modify] https://crrev.com/097f9cde453ea57eb4aa037f44add782391c5eb9/ui/views/view_observer.h

Project Member

Comment 23 by bugdroid1@chromium.org, Apr 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cf2905163bc2e0ec4ae52c533e751f4de7cde20

commit 1cf2905163bc2e0ec4ae52c533e751f4de7cde20
Author: pkalinnikov <pkalinnikov@chromium.org>
Date: Tue Apr 25 12:31:34 2017

Revert of Introduce a type of View background that stays in sync with its host (patchset #10 id:180001 of https://codereview.chromium.org/2816193002/ )

Reason for revert:
Seems causing a lot of test crashes on "Linux Chromium OS ASan" bots (ash_unittests, browser_tests, interactive_ui_tests, unit_tests).

Original issue's description:
> Introduce a type of View background that stays in sync with its host
> View's native theme.
>
> This fixes a few bugs where we weren't using the right native theme,
> whether by not updating after the NativeTheme changes or by trying to
> access the NativeTheme before the View is added to a hierarchy (which
> yields the default NativeTheme --- for most platforms, this didn't
> effectively create a bug as there's only one NativeTheme).
>
> Best example is that now the sad tab respects the GTK native theme.
>
> Get rid of Ash's tray_constants::kBackgroundColor in favor of using the
> bubble background color from the NativeTheme.
>
> BUG= 711183 , 693282 
> TBR=stevenjb@chromium.org
>
> Review-Url: https://codereview.chromium.org/2816193002
> Cr-Commit-Position: refs/heads/master@{#466847}
> Committed: https://chromium.googlesource.com/chromium/src/+/097f9cde453ea57eb4aa037f44add782391c5eb9

TBR=msw@chromium.org,tdanderson@chromium.org,stevenjb@chromium.org,estade@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 711183 , 693282 

Review-Url: https://codereview.chromium.org/2835233005
Cr-Commit-Position: refs/heads/master@{#466953}

[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/audio/volume_view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/tray/system_tray.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/tray/tray_constants.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/tray/tray_constants.h
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/tray_accessibility.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/user/user_card_view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/user/user_view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ash/system/user/user_view.h
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/chrome/browser/ui/views/sad_tab_view.h
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/message_center/views/message_bubble_base.h
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/views/background.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/views/background.h
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/views/bubble/tray_bubble_view.h
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/views/view.cc
[modify] https://crrev.com/1cf2905163bc2e0ec4ae52c533e751f4de7cde20/ui/views/view_observer.h

Project Member

Comment 24 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56fc9d639f67506841a0cb90a421a869e5107eea

commit 56fc9d639f67506841a0cb90a421a869e5107eea
Author: estade <estade@chromium.org>
Date: Fri Apr 28 22:28:06 2017

Introduce a type of View background that stays in sync with its host
View's native theme.

This fixes a few bugs where we weren't using the right native theme,
whether by not updating after the NativeTheme changes or by trying to
access the NativeTheme before the View is added to a hierarchy (which
yields the default NativeTheme --- for most platforms, this didn't
effectively create a bug as there's only one NativeTheme).

Best example is that now the sad tab respects the GTK native theme.

Get rid of Ash's tray_constants::kBackgroundColor in favor of using the
bubble background color from the NativeTheme.

This is a reland of 097f9cde453ea57eb4aa037f44add782391c5eb9 with fix
for asan failure.

BUG= 711183 ,  693282 
TBR=stevenjb@chromium.org,tdanderson@chromium.org

Review-Url: https://codereview.chromium.org/2838273002
Cr-Commit-Position: refs/heads/master@{#468157}

[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/audio/volume_view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/tray/system_tray.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/tray/tray_constants.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/tray/tray_constants.h
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/tray/tray_details_view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/tray/tray_popup_utils.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/tray_accessibility.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/user/user_card_view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/user/user_view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ash/system/user/user_view.h
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/chrome/browser/ui/views/sad_tab_view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/chrome/browser/ui/views/sad_tab_view.h
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/message_center/views/message_bubble_base.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/message_center/views/message_bubble_base.h
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/views/background.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/views/background.h
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/views/bubble/tray_bubble_view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/views/bubble/tray_bubble_view.h
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/views/view.cc
[modify] https://crrev.com/56fc9d639f67506841a0cb90a421a869e5107eea/ui/views/view_observer.h

Labels: Needs-Feedback
estade@ Trying to verify this bug on M59. Is this fixed? Is the second CL "Introduce a type of View background..." not going to be merged to M59?
correct, the second one doesn't need to be merged. It should be fixed. It might be hard to verify unless you have a color picker on your device to detect the exact color values of pixels on screen.
Status: Verified (was: Fixed)
Thanks estade@

Verified on 9460.48.0, 59.0.3071.67 using color picker.

Sign in to add a comment