New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711168 link

Starred by 1 user
Status: Fixed
Owner:
dtrainor@chromium.org
Closed: Apr 2017
Cc:
█ nyquist@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

[IPH] Fix TextBubble to be more robust

Project Member Reported by dtrainor@chromium.org, Apr 13 2017 
There are a few issues with the text bubble:
- Moving the anchor rect doesn't work correctly (arrow doesn't move, top/bottom orientation doesn't work correctly).
- The ViewAnchoredTextBubble also doesn't detach on all code paths.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da26a507e1367331f15769f75797fd70032a08b8

commit da26a507e1367331f15769f75797fd70032a08b8
Author: dtrainor <dtrainor@chromium.org>
Date: Thu Apr 13 21:55:13 2017

Improve (ViewAnchored)TextBubble logic

Make the TextBubble more robust and fix a few bugs:
- Make sure that moving the arrow actually triggers a drawable
invalidation.
- Make the ViewAnchoredTextBubble much more robust to View changes
(translate positioning, removing from hierarchy, visibility changes,
etc.).
- Make the TextBubble try to maintain it's orientation (above vs. below)
the anchor rect.
- Make the TextBubble properly swap orientations if the anchor rect
moves and requires it.
- Fix ViewAnchoredTextBubble to properly detach listeners on all dismiss
paths (instead of just an explicit call to dismiss() on the bubble).

BUG= 711168 

Review-Url: https://codereview.chromium.org/2818693002
Cr-Commit-Position: refs/heads/master@{#464561}

[modify] https://crrev.com/da26a507e1367331f15769f75797fd70032a08b8/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java
[modify] https://crrev.com/da26a507e1367331f15769f75797fd70032a08b8/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ArrowBubbleDrawable.java
[modify] https://crrev.com/da26a507e1367331f15769f75797fd70032a08b8/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/TextBubble.java
[modify] https://crrev.com/da26a507e1367331f15769f75797fd70032a08b8/chrome/android/java/src/org/chromium/chrome/browser/widget/textbubble/ViewAnchoredTextBubble.java

Comment 2 by dtrainor@chromium.org, Apr 17 2017

Status: Fixed (was: Started)
►

Sign in to add a comment