New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711146 link

Starred by 2 users
Status: Fixed
Owner:
█ staraz@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
danakj@chromium.org
weiliangc@chromium.org
rjkroege@chromium.org
vmp...@chromium.org
sadrul@chromium.org
piman@chromium.org
enne@chromium.org
varkha@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 717760
issue 717959
Blocking:
issue 717514
issue 732572



Sign in to add a comment

Clarify RendererSettings and unify between Chrome and Mus

Project Member Reported by fsam...@chromium.org, Apr 13 2017 
I'm super duper confused about cc::RendererSettings. They look like they're settings for the display compositor, but they're also plumbed through to the renderer. Why?

Can we rename these to DisplayCompositorSettings and not use them in the renderer? WDYT?

Comment 1 by fsam...@chromium.org, Apr 13 2017 

Assigned to staraz@ for followup with danakj@, enne@, piman@ et al to do a little bit of code archeology.

Comment 2 by danakj@chromium.org, Apr 13 2017 

Theyre settings for DirectRenderer. They shouldn't go to LTH, and the ones that LTH needs should be moved/copied to LayerTreeSettings.

Comment 3 by staraz@chromium.org, Apr 19 2017

Status: Started (was: Assigned)

Comment 4 by fsam...@chromium.org, Apr 19 2017

Labels: Type-Feature

Comment 5 by staraz@chromium.org, May 3 2017

Blockedon: 717760

Comment 6 by staraz@chromium.org, May 3 2017

Blockedon: 717959

Comment 7 by staraz@chromium.org, May 3 2017 

My CL for this has grown huge. I'm dividing this into smaller sub-tasks filing 
bugs to keep track of them.

Comment 8 by fsam...@chromium.org, May 3 2017

Cc: weiliangc@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, May 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72301d1488da45405e793f7d089585f9996c742b

commit 72301d1488da45405e793f7d089585f9996c742b
Author: staraz <staraz@chromium.org>
Date: Wed May 10 16:57:02 2017

Remove |highp_threshold_min| from GLRenderer()

GLRenderer() takes a RendererSettings which contains a highp_threshold_min as a
field and a separate highp_rhreshold_min parameter.

In practice, either RendererSettings::highp_threshold_min or a default 0 is
passed to GLRenderer(). Therefore, GLRenderer() should use
RendererSettings::highp_threshold_min instead.

BUG= 711146 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2870253004
Cr-Commit-Position: refs/heads/master@{#470615}

[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/output/gl_renderer.cc
[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/output/gl_renderer.h
[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/output/gl_renderer_unittest.cc
[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/output/overlay_unittest.cc
[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/surfaces/display.cc
[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/test/pixel_test.cc
[modify] https://crrev.com/72301d1488da45405e793f7d089585f9996c742b/cc/test/pixel_test.h
Project Member

Comment 10 by bugdroid1@chromium.org, May 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f98e54b610b6f3ddbf07cc610380a77e554c7c5

commit 3f98e54b610b6f3ddbf07cc610380a77e554c7c5
Author: staraz <staraz@chromium.org>
Date: Fri May 12 21:21:23 2017

Initialize RendererSettings in ContextFactory

Implementations of ContextFactory initialize RendererSettings based on switches
on the command line. ui::Compositor gets RendererSettings via
ContextFactory::GetRendererSettings.

ui::Compositor::GetRendererSettings and
ContextFactory::GetImageTextureTarget is removed since it is no longer
being used.

By centralizing the initialization of RendererSettings into ContextFactory,
there is no longer any usage of LayerTreeSettings::renderer_settings outside of
LayerTreeHostImpl. Therefore, this CL brings us one step closer to having
separate LayerTreeSettings and RendererSettings.

BUG= 711146 

Review-Url: https://codereview.chromium.org/2879463002
Cr-Commit-Position: refs/heads/master@{#471445}

[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/aura/mus/mus_context_factory.h
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/BUILD.gn
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/compositor.cc
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/compositor.h
[add] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/compositor_util.cc
[add] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/compositor_util.h
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/test/fake_context_factory.cc
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/test/fake_context_factory.h
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/3f98e54b610b6f3ddbf07cc610380a77e554c7c5/ui/compositor/test/in_process_context_factory.h

Comment 11 by fsam...@chromium.org, May 23 2017

Cc: varkha@chromium.org
Project Member

Comment 12 by bugdroid1@chromium.org, May 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88677427eb90210e1f60202602a3dc1eace69da5

commit 88677427eb90210e1f60202602a3dc1eace69da5
Author: staraz <staraz@chromium.org>
Date: Fri May 26 13:53:03 2017

Move RendererSettings:buffer_to_texture_target_map to LayerTreeSettings

ContextFactory populates and stores the buffer to OpenGL texture target map.
ui::Compositor copies it into
LayerTreeSettings before using it to create a LayerTreeHost.

The map is used by both LayerTreeHost and cc::Display to create
ResourceProviders but it doesn't go into DirectRenderer or its subclasses.
Letting ContextFactory populate the map centralize the logic compared to the
current state (ui::Compositor populates the map by calling
ContextFactory::GetImageTextureTarget).

BUG= 711146 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2857363004
Cr-Commit-Position: refs/heads/master@{#474999}

[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/test/layer_tree_pixel_test.h
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/test/layer_tree_test.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/test/layer_tree_test.h
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/test/pixel_test.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_host_perftest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/88677427eb90210e1f60202602a3dc1eace69da5/ui/compositor/compositor.cc

Comment 13 by staraz@chromium.org, May 30 2017

Blocking: 717514
Project Member

Comment 14 by bugdroid1@chromium.org, May 31 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da

commit b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da
Author: Alex Zhang <staraz@chromium.org>
Date: Wed May 31 22:13:37 2017

Move RendererSettings::preferred_tile_format to LayerTreeSettings

preferred_tile_format is used by LayerTreeHostImpl to create ImageDecodeCaches
and RasterBufferProviders. Therefore, it should live in LayerTreeSettings.

Bug:  711146 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I105204a766b38334c036d25641316594e1940275
Reviewed-on: https://chromium-review.googlesource.com/518222
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476056}
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/cc/output/renderer_settings.cc
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/cc/output/renderer_settings.h
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/cc/trees/layer_tree_settings.cc
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/ui/compositor/compositor.cc
[modify] https://crrev.com/b450b96f42a6a7328ee0cdcdf78ad4ea95dca8da/ui/compositor/compositor_util.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b39b759e7183ef047fd09940251cc4d607421dec

commit b39b759e7183ef047fd09940251cc4d607421dec
Author: Alex Zhang <staraz@chromium.org>
Date: Thu Jun 01 21:05:41 2017

Add ResourceSettings class to LayerTreeSettings and RendererSettings

ResourceSettings holds the field that are used by LayerTreeHostImpl and
LayerTreeHostImpl no longer needs LayerTreeSettings::renderer_settings.

cc: :Display to create ResourceProviders. With ResourceSettings,
Bug:  711146 
Change-Id: Ib3594b35cbf698913fde91a5ec72c6323aa561d6
Reviewed-on: https://chromium-review.googlesource.com/517748
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476435}
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/BUILD.gn
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/output/renderer_settings.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_provider.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_provider.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_provider_unittest.cc
[add] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_settings.cc
[add] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_settings.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/surfaces/display.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/test/fake_resource_provider.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/test/layer_tree_test.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/test/pixel_test.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/aura/mus/mus_context_factory.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/compositor.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/compositor.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/compositor_util.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/fake_context_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/fake_context_factory.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/in_process_context_factory.h
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b39b759e7183ef047fd09940251cc4d607421dec

commit b39b759e7183ef047fd09940251cc4d607421dec
Author: Alex Zhang <staraz@chromium.org>
Date: Thu Jun 01 21:05:41 2017

Add ResourceSettings class to LayerTreeSettings and RendererSettings

ResourceSettings holds the field that are used by LayerTreeHostImpl and
LayerTreeHostImpl no longer needs LayerTreeSettings::renderer_settings.

cc: :Display to create ResourceProviders. With ResourceSettings,
Bug:  711146 
Change-Id: Ib3594b35cbf698913fde91a5ec72c6323aa561d6
Reviewed-on: https://chromium-review.googlesource.com/517748
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476435}
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/BUILD.gn
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/output/renderer_settings.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_provider.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_provider.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_provider_unittest.cc
[add] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_settings.cc
[add] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/resources/resource_settings.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/surfaces/display.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/test/fake_resource_provider.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/test/layer_tree_test.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/test/pixel_test.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/aura/mus/mus_context_factory.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/compositor.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/compositor.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/compositor_util.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/fake_context_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/fake_context_factory.h
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/b39b759e7183ef047fd09940251cc4d607421dec/ui/compositor/test/in_process_context_factory.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90722d947fce99daabd2bda4703e1a735a667ac0

commit 90722d947fce99daabd2bda4703e1a735a667ac0
Author: Alex Zhang <staraz@chromium.org>
Date: Tue Jun 06 01:09:14 2017

[Reland] Add ResourceSettings class to LayerTreeSettings and RendererSettings

Extract fields of RenderSettings that are used to create ResourceProviders into
ResourceSettings.

With ResourceSettings, LayerTreeHostImpl no longer needs
LayerTreeSettings::renderer_settings.

Both LayerTreeSettings and RendererSettings have ResourceSettings because
ResourceProviders are created in LayerTreeHostImpl and cc::Display.

This CL is an updated version of 517748. enable_color_correct_rasterization has
been moved back into LayerTreeSettings from ResourceSettings because cc::Display
uses false as enable_color_correct_rasterization when creating its
ResourceProvider.

Bug:  711146 
Change-Id: Ia6fb4b89273ae29b412f8fea19b40518043cfce7
Reviewed-on: https://chromium-review.googlesource.com/524004
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: ccameron chromium <ccameron@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#477137}
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/BUILD.gn
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/layers/picture_layer_impl_unittest.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/output/renderer_settings.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/resources/resource_provider.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/resources/resource_provider.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/resources/resource_provider_unittest.cc
[add] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/resources/resource_settings.cc
[add] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/resources/resource_settings.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/surfaces/display.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/test/fake_resource_provider.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/test/layer_tree_test.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/test/pixel_test.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/tiles/tile_manager_unittest.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/content/browser/compositor/gpu_process_transport_factory.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/content/browser/compositor/gpu_process_transport_factory.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/aura/mus/mus_context_factory.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/aura/mus/mus_context_factory.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/compositor.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/compositor.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/compositor_util.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/test/fake_context_factory.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/test/fake_context_factory.h
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/test/in_process_context_factory.cc
[modify] https://crrev.com/90722d947fce99daabd2bda4703e1a735a667ac0/ui/compositor/test/in_process_context_factory.h

Comment 18 by fsam...@chromium.org, Jun 12 2017

Blocking: 732572

Comment 19 by danakj@chromium.org, Jun 12 2017

Blocking: -601863
Project Member

Comment 20 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/903cb6ab79a961cc641cfea5ef5271be12c1a396

commit 903cb6ab79a961cc641cfea5ef5271be12c1a396
Author: Alex Zhang <staraz@chromium.org>
Date: Tue Jun 13 13:40:58 2017

Remove LayerTreeSettings::renderer_settings

Remove renderer_settings field from LayerTreeSettings. RendererSettings
should consumed by only DirectRenderers and its subclasses, not
LayerTreeHost.

Following a series of CLs, renderer_settings field is now removed from
LayerTreeSettings.

LayerTreeTests now creates their own RendererSettings in
RequestNewCompositorFrameSink and passes it to
CreateCompositorFrameSink.

RenderWidgetCompositor no longer initialize RendererSettings since it is
done in ContextFactory.

Bug:  711146 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iaf3ebcabdbbe7702a4236ee624e74183834b9ea9
Reviewed-on: https://chromium-review.googlesource.com/529265
Commit-Queue: Xingyu Zhang <staraz@chromium.org>
Reviewed-by: Bo Liu <boliu@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479000}
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/layers/texture_layer_unittest.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/output/renderer_pixeltest.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/output/renderer_settings.h
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/layer_tree_pixel_test.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/layer_tree_pixel_test.h
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/layer_tree_test.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/layer_tree_test.h
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/pixel_test.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/pixel_test.h
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/test_compositor_frame_sink.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/test/test_compositor_frame_sink.h
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_host_impl_unittest.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_host_perftest.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_host_pixeltest_blending.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_host_unittest.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_host_unittest_context.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_host_unittest_copyrequest.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/content/browser/renderer_host/compositor_impl_android.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/content/test/layouttest_support.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/ui/compositor/compositor.cc
[modify] https://crrev.com/903cb6ab79a961cc641cfea5ef5271be12c1a396/ui/compositor/compositor_util.cc

Comment 21 by staraz@chromium.org, Jun 13 2017

Status: Fixed (was: Started)

Comment 22 by staraz@chromium.org, Jun 13 2017

Status: Started (was: Fixed)
Reopening this issue since we want RendererSettings plumbed to DisplayProviders.

Comment 23 by staraz@chromium.org, Jun 13 2017

Status: Fixed (was: Started)

Comment 24 by danakj@chromium.org, Jun 13 2017 

Please don't forget to look into the highp_threshold_max becoming unset outside of layout tests too.

Comment 25 by fsam...@chromium.org, Jun 13 2017

Blocking:

Comment 26 by lafo...@chromium.org, Feb 26 2018

Components: -Internals>MUS Internals>Services>WindowService
►

Sign in to add a comment