New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711141 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Email to this user bounced
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-25
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[webnfc]Two case issues were found in NFC layout test case

Reported by canx....@intel.com, Apr 13 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce the problem:
Steps to reproduce the problem:
Test case:https://chromium.googlesource.com/chromium/src.git/+/master/third_party/WebKit/LayoutTests/nfc/push.html
1. Check the line#117 and Line#137. it is duplicated.
2. Check the Line#143. the "()" of cancelPush method is missing.

What is the expected behavior?
No case issue.

What went wrong?
[1] duplicated issue in test case Line#117 and Line#137
Line #115 nfc_test(nfc => {
Line #116  return navigator.nfc.push(test_buffer_data).then(() => {
Line #117    nfc.assertNFCMessagesEqual(test_buffer_data, nfc.mockNFC.pushedMessage());
Line #118  });
Line #119 }, 'nfc.push ArrayBuffer with default NFCPushOptions.');

Line #135 nfc_test(nfc => {
Line #136  return navigator.nfc.push(test_buffer_data).then(() => {
Line #137    nfc.assertNFCMessagesEqual(test_buffer_data, nfc.mockNFC.pushedMessage());
Line #138  });
Line #139 }, 'Push ArrayBuffer with default NFCPushOptions.');

[2]The syntax issue in test case Line#143.
Line #141 nfc_test(nfc => {
Line #142   return navigator.nfc.push(test_text_data)
Line #143       .then(() => { navigator.nfc.cancelPush });
Line #144 }, 'nfc.cancelPush should succeed if there is pending push operation.');

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 57.0.2987.133  Channel: stable
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 25.0 r0
 
Cc: rbasuvula@chromium.org
Components: Blink
Labels: M-59 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Tested the issue on chrome Stable #57.0.2987.133, Canary 59.0.3069.0 in Windows 10.0 & 7 and was able to reproduce the issue.

This is a Non-Regression issue since seeing this from M30 #30.0.1549.0, Making the status to Untriaged so that the issue would get addressed.

Note : Able to reproduce the issue in MAC 10.12 and Linux Ubuntu 14.04.

Thank you.

Comment 2 by canx....@intel.com, Apr 13 2017

Cc:wanming.lin@intel.com , alexander.shalamov@intel.com , mikhail.pozdnyakov@intel.com

This issue is case issue,Please take a look. thanks.

Comment 3 by junov@chromium.org, Apr 13 2017

Components: -Blink Blink>Network

Comment 4 by ricea@chromium.org, Apr 14 2017

Cc: rijubrat...@intel.com kenneth....@intel.com
Components: -Blink>Network Blink
Owner: alexande...@intel.com
Assigning NFC owners.

It looks like NFC does not have its own component. Sending it back to Blink.
Cc: sshruthi@chromium.org
Components: -Blink Blink>Bluetooth
Bluetooth folks, do you mind if I park this issue in your label?

+sshruthi, do we need an NFC label?

Comment 6 by sshru...@google.com, Apr 17 2017

dglazkov@, we could. Do we have a team that could own this component and triage it on a regular basis?
I've requested a component for NFC in  issue 712314 .

Comment 8 by scheib@chromium.org, Apr 17 2017

NextAction: 2017-04-25
NextAction: Set to have component updated to NFC.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2942673dd8357b4bc530973b5a3a645e574578c

commit a2942673dd8357b4bc530973b5a3a645e574578c
Author: alexander.shalamov <alexander.shalamov@intel.com>
Date: Tue Apr 18 12:49:04 2017

[webnfc] Remove duplicate test case from layout test

This CL fixes one test case and removes one duplicate.

BUG= 711141 

Review-Url: https://codereview.chromium.org/2825033002
Cr-Commit-Position: refs/heads/master@{#465209}

[modify] https://crrev.com/a2942673dd8357b4bc530973b5a3a645e574578c/third_party/WebKit/LayoutTests/nfc/push.html

Cc: -kenneth....@intel.com -rijubrat...@intel.com
Status: Fixed (was: Untriaged)
Components: -Blink>Bluetooth Blink>NFC
canx.cao@ Could you please verify? Thanks.

Comment 13 Deleted

The layout test file has been updated.This issue has been fixed.
Close.
Status: Verified (was: Fixed)

Sign in to add a comment