New issue
Advanced search Search tips

Issue 711139 link

Starred by 1 user
Status: Fixed
Owner:
mheikal@chromium.org
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: ----



Sign in to add a comment

CamelCaseName prefixes should be stripped by java_cpp_enum.py

Project Member Reported by estevenson@chromium.org, Apr 13 2017 
When creating an enum with shouty names:

enum FooBar {
  FOO_BAR_TEST,
  FOO_BAR_TEST2
}

If all entries match the enum name (FOO_BAR -> FooBar), then the FOO_BAR prefix is stripped from the generated java enum.

This should also be supported for CamelCase naming:

enum FooBar {
  FooBarTest,
  FooBarTest2
}

Should become TEST and TEST2 on the java side.

Comment 1 by agrieve@chromium.org, Nov 1 2017

Owner: mheikal@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2422f44936b31ef50641180f99153b716a93d378

commit 2422f44936b31ef50641180f99153b716a93d378
Author: Mohamed Heikal <mheikal@google.com>
Date: Mon Nov 06 17:23:06 2017

CamelCase prefixes now stripped by java_cpp_enum.py

java_cpp_enum.py which converts from cpp to java enums currently only
strips SHOUT_CASE prefixes. This change should allow it to also strip
CamelCase prefixes.

Bug:  711139 
Change-Id: I3b81467d39e374e50320448b3b0073cb69d8f883
Reviewed-on: https://chromium-review.googlesource.com/750388
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@google.com>
Cr-Commit-Position: refs/heads/master@{#514161}
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/android_webview/java/src/org/chromium/android_webview/AwContents.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/build/android/gyp/java_cpp_enum.py
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/build/android/gyp/java_cpp_enum_tests.py
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/java/src/org/chromium/chrome/browser/IntentHandler.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/java/src/org/chromium/chrome/browser/suggestions/SuggestionsNavigationDelegateImpl.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/javatests/src/org/chromium/chrome/browser/HTTPSTabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/content/public/android/javatests/src/org/chromium/content/browser/ContentViewPointerTypeTest.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/content/shell/android/java/src/org/chromium/content_shell/ShellViewAndroidDelegate.java
[modify] https://crrev.com/2422f44936b31ef50641180f99153b716a93d378/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java

Comment 3 by mheikal@chromium.org, Dec 19 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment