LengthBox::end is not capitalized after Blink rename. |
||||
Issue descriptionSee https://cs.chromium.org/webrtc/src/third_party/WebKit/Source/platform/LengthBox.h?q=LengthBox::end&l=83 LengthBox::end is a method, but was not capitalized after the rename, even though similar methods like LengthBox::Start and LengthBox::Over were capitalized.
,
Apr 25 2017
I had a CL to fix this, but it looks like this was already fixed by https://chromium.googlesource.com/chromium/src/+/786615ba373b0e7a6e488364c49f2cf56942de3f.
,
Apr 25 2017
Oh wait, there's two end() functions...
,
Apr 25 2017
Yeah it's a bit confusing. There's a static LengthBox::End and a member function LengthBox::end.
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa4db17d5939f767c11d1cae3fe2139dcf928400 commit fa4db17d5939f767c11d1cae3fe2139dcf928400 Author: Daniel Cheng <dcheng@chromium.org> Date: Tue Apr 25 23:29:10 2017 Remove unused LengthBox helpers. end() was incorrectly named after the Blink rename. As it (and several other helpers) aren't used, just remove them. Bug: 711138 Change-Id: I2b607456eccaa89af7231067ccfbebb29a150fc8 Reviewed-on: https://chromium-review.googlesource.com/486151 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#467163} [modify] https://crrev.com/fa4db17d5939f767c11d1cae3fe2139dcf928400/third_party/WebKit/Source/platform/LengthBox.cpp [modify] https://crrev.com/fa4db17d5939f767c11d1cae3fe2139dcf928400/third_party/WebKit/Source/platform/LengthBox.h
,
Apr 25 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by dcheng@chromium.org
, Apr 13 2017Owner: dcheng@chromium.org
Status: Assigned (was: Untriaged)