New issue
Advanced search Search tips

Issue 711129 link

Starred by 1 user
Status: Verified
Owner:
steve...@chromium.org
Closed: Apr 2017
Cc:
sdantul...@chromium.org
tbuck...@chromium.org
abod...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Explanation string for cant change channel needs cleaning

Project Member Reported by dhadd...@chromium.org, Apr 13 2017 
Kevin / 9455.0.0 / 59.0.3068.1

Open MD Settings
Go to About ChromeOS
Detailed build settings 

Can't change channel

Comment 1 by dhadd...@chromium.org, Apr 13 2017

Summary: Explanation string for cant change channel needs cleaning (was: Can't change channel on MD settings)
Only owner can do that. Changing this bug as I found something else.

The explanation text when a non-owner wants to change channel needs to be cleaned up. It has a comma space period at the end:

"This setting is managed by the device owner, ."

Comment 2 by tbuck...@chromium.org, Apr 13 2017

Cc: tbuck...@chromium.org
Labels: Proj-MaterialDesign-WebUI Hotlist-MD-Settings-AboutCrOS
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by steve...@chromium.org, Apr 13 2017

Status: Started (was: Assigned)

Comment 4 by steve...@chromium.org, Apr 13 2017 

The owner name is supposed to be there.
CL: https://codereview.chromium.org/2815363002/

Comment 5 by michae...@chromium.org, Apr 13 2017 

Dang, I "fixed" this in https://codereview.chromium.org/2746643002 and broke it again. Let's make sure this is in the 59 branch (I can own that if you like).
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4021fa979a172a4509d6212655c39c1fe6a791

commit 1d4021fa979a172a4509d6212655c39c1fe6a791
Author: stevenjb <stevenjb@chromium.org>
Date: Thu Apr 13 21:04:33 2017

MD Settings: About: Provide correct indicator name

BUG= 711129 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2815363002
Cr-Commit-Position: refs/heads/master@{#464545}

[modify] https://crrev.com/1d4021fa979a172a4509d6212655c39c1fe6a791/chrome/browser/resources/settings/about_page/detailed_build_info.html

Comment 7 by steve...@chromium.org, Apr 13 2017

Status: Fixed (was: Started)

Comment 8 by sdantul...@chromium.org, May 8 2017

Status: Verified (was: Fixed)
9460.30.0, 59.0.3071.41
►

Sign in to add a comment