New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711125 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 710253
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Slim down and cleaning up telemetry media benchmarks

Project Member Reported by crouleau@chromium.org, Apr 13 2017

Issue description

Design doc here: https://docs.google.com/document/d/1TvUWPl6diK3DTJdSWMOcdz-6qnKC6KEHAZqoBBD8lIc/edit#

Also I have other smaller fixes that will also reduce the benchmark duration. 
 
Components: -Speed>Telemetry Speed>Benchmarks
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a48a45ac9c3138e306f19df0b3fc1974ffe33ec

commit 6a48a45ac9c3138e306f19df0b3fc1974ffe33ec
Author: crouleau <crouleau@chromium.org>
Date: Thu Apr 13 03:55:49 2017

Do not play the whole media file before seeking.

I also fixed some comments and fixed pylint line length errors.

This was a bug introduced in crrev/346923003.
Originally we would start playing the video and wait until it got to 1
second, and then we would seek around in it. After crrev/346923003 we
would instead play the entire video and then seek around in it.

sandersd@'s crrev/1962563005 noticed this bug and commented on it, but
we haven't gotten around to fixing it until now.

This change should reduce load on Speed infra machines by reducing the benchmark duration for tough_video_cases_extra from ~5 minutes to ~3 minutes. we get to skip the initial playback for 14 of the pages in tough_video_cases_extra. the video length of test content is around 10 seconds on average, and this change will make us play only 1 second of the video instead of the whole video before we start seeking. So 14*(10-1) = 126 seconds.

Also, I noticed that two of the pages in tough_video_cases are also seeking pages, not time_to_play pages, so this will reduce the runtime for those as well.

In addition to reducing the load, this change will also make seek times become the measurement that they were originally supposed to be. Seek time cold currently doesn't actually measure cold seek time because that part of the video that was seeked to was already played once.

BUG= 711125 

Review-Url: https://codereview.chromium.org/2813383002
Cr-Commit-Position: refs/heads/master@{#464288}

[modify] https://crrev.com/6a48a45ac9c3138e306f19df0b3fc1974ffe33ec/tools/perf/page_sets/tough_video_cases.py

Cc: johnchen@chromium.org
The change above dropped the benchmark duration from 5 minutes to 2 minutes according to https://chromeperf.appspot.com/report?sid=6c9061b1943641a81dd022a50b91bac79d47ee995594e60788ab0da24e127e13 Not sure why my math was a little bit off: I predicted a drop from 5 to 3.
Mergedinto: 710253
Status: Duplicate (was: Assigned)
Whoops, looks like I already had a bug for this.

Sign in to add a comment