Feedback dialog doesn't show for broken cryptohome sometimes |
||||||||
Issue descriptionMy test user: test.filemgr@gmail.com the cryptohome tool won't work with an email address with a period in it but if you remove the period it will. Steps: 1. Go to VT2 shell and run as root to change cryptohome password cryptohome --action=migrate_key --user=testfilemgr@gmail.com 2. Try password 4 times 3. Enter password into GAIA A dialog is shown saying your profile is broken. Press CONTINUE. The next dialog is never shown
,
Apr 13 2017
hmm. I cannot reproduce this one. I created a debug.xqiang@gmail.com test account. 1. cryptohome --action=migrate_key --user=debugxqiang@gmail.com Fot step one, it has to be "debugxqiang", otherwise key migration is failed. These two accounts should be identical. Not sure if there could be something wrong. Then follow the steps. I could see feedback UI shown up. Roughly go through code, I don't see anything that is processing user email. That means user email name should not matter.
,
Apr 14 2017
Cryptohome id uses canonicalized user email [1]. If it is @gmail.com, '.' would be stripped from it to have consistent behavior with gmail. It should not affect the feedback window though. If we get it happen again, please collect chrome user log. [1]: https://cs.chromium.org/chromium/src/google_apis/gaia/gaia_auth_util.cc?rcl=5412d363b9dec0df74ab2080665dc30cb3d9382f&l=45
,
Apr 17 2017
Kevin 9460.0.0 / 59.0.3068.1 I am now seeing this for addresses without a period in their name too. Updating title
,
Apr 21 2017
will take a closer look
,
Apr 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/24d15b15c85b8d3a60c6985add50824fa6602467 commit 24d15b15c85b8d3a60c6985add50824fa6602467 Author: xiyuan <xiyuan@chromium.org> Date: Fri Apr 21 18:13:08 2017 cros: Fix race on feedback extension loading - Move ExtensionHost check before loading feedback extension to fix the race that ExtensionHost check could run after the loading makes feedback background page up and running; - Handle the case where feedkback background host already exists, just in case. - Add a retry in EnsureFeedbackUI to be sure the UI will be created; BUG= 711123 Review-Url: https://codereview.chromium.org/2837613002 Cr-Commit-Position: refs/heads/master@{#466395} [modify] https://crrev.com/24d15b15c85b8d3a60c6985add50824fa6602467/chrome/browser/chromeos/login/ui/login_feedback.cc
,
Apr 21 2017
,
Apr 22 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0afa4047734595061336ff666da0ed39ce9e5894 commit 0afa4047734595061336ff666da0ed39ce9e5894 Author: Xiyuan Xia <xiyuan@chromium.org> Date: Mon Apr 24 15:55:04 2017 Merge "cros: Fix race on feedback extension loading" > - Move ExtensionHost check before loading feedback extension to fix the > race that ExtensionHost check could run after the loading makes > feedback background page up and running; > - Handle the case where feedkback background host already exists, > just in case. > - Add a retry in EnsureFeedbackUI to be sure the UI will be created; > > BUG= 711123 > > Review-Url: https://codereview.chromium.org/2837613002 > Cr-Commit-Position: refs/heads/master@{#466395} > (cherry picked from commit 24d15b15c85b8d3a60c6985add50824fa6602467) Review-Url: https://codereview.chromium.org/2836063002 . Cr-Commit-Position: refs/branch-heads/3071@{#163} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/0afa4047734595061336ff666da0ed39ce9e5894/chrome/browser/chromeos/login/ui/login_feedback.cc
,
Apr 24 2017
,
Jan 22 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by zalcorn@chromium.org
, Apr 13 2017