New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711118 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Cr50: Updater not executed because the cache file in /var is not correct.

Project Member Reported by hungte@chromium.org, Apr 13 2017

Issue description

This is an issue found in last Eve build.

What steps will reproduce the problem?
(1) Partner prepares one device and verified it runs tests.
(2) Partner used eMMC from that as the golden sample of copy machine 
(3) The copy machine cloned emmc contents to all manufactured devices
(4) Start device

What is the expected result?
Cr50 should be updated.

What happens instead?
Cr50 not updated, because it saw the cache file from the "golden sample", which Cr50 there has been updated.

The factory team will work on something to delete cache files when eMMC is changed, but we also believe Cr50 should use some better mechanism instead of trusting non-verified cache file.
 
Cc: -phoenixshen@chromium.org mruthven@chromium.org
Labels: -Pri-3 Pri-2
Status: Available (was: Untriaged)
Do you guys think this will impact Reef?
We've found the same issue in Electro, and have a workaround:
Don't boot the golden sample before copy the emmc contents to other devices.
So I think it's ok for now.

Comment 3 by hungte@chromium.org, Apr 13 2017

> Don't boot the golden sample before copy the emmc contents to other devices.

This may be hard to check when you have multiple projects building in different ODMs (or even different unit in same ODM).

@will As #2 indicated, please deliver this message so all reef projects are aware of that.
Another workaround we did on Electro is delete /var/cache/cr50-* and then reboot at the beginning of factory test to force cr50 update.
Hungte, do you think we should do this on all reef projects?

Comment 5 by hungte@chromium.org, Apr 18 2017

Re#4 So far you can do that on reef factory branch, although I think having a job to check if storage SN has been changed then delete cache is more general.
re #3, who should I deliver this message to? Quanta?

Comment 7 by mruthven@google.com, Apr 18 2017

To force cr50 update to run you need to delete /var/cache/cr50* not /var/cache/cr50-*
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/c3b4e0d8dce4688578f81e677e3fa6f90471266e

commit c3b4e0d8dce4688578f81e677e3fa6f90471266e
Author: Hung-Te Lin <hungte@chromium.org>
Date: Mon Jun 26 07:17:41 2017

init: Add a goofy.d/device service 'device_id.sh'

A new service that will track and provision right device ID when system
reboots.

BUG= chromium:711200 , chromium:711118 
TEST=manually booted on device.

Change-Id: I0dfaa45bce50a48b9f70d199a422e570b3043cba
Reviewed-on: https://chromium-review.googlesource.com/476455
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[add] https://crrev.com/c3b4e0d8dce4688578f81e677e3fa6f90471266e/init/goofy.d/device/device_id/README.md
[add] https://crrev.com/c3b4e0d8dce4688578f81e677e3fa6f90471266e/init/goofy.d/device/device_id/cr50-cache.sh
[add] https://crrev.com/c3b4e0d8dce4688578f81e677e3fa6f90471266e/init/goofy.d/device/device_id.sh

Wouldn't it be simpler to augment the 'golden image creation' process with
a list of files to remove, so that the cr50 cache does not make it into the
golden image?
Owner: pihsun@chromium.org
Status: Fixed (was: Available)
Re#9

We do have tools and process to create a golden image without creating cr50 files, but it's hard to make sure all partners will always remember doing things in right way, so it's better to have something that can check and fix broken stuff.

Comment 11 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment