+cleer

There's a problem with using android's dialog at the bottom of the screen. It resizes itself by animating but assumes the top stays static. A possible solution is to always show the full url when chrome home is enabled.

Deleted: recording.mp4 3.2 MB

	recording.mp4 3.2 MB View Download

I can set a max height on the popup as well so it doesn't take up the entire screen for long URLs (i.e. 50% of the screen or some dp value).

Discussed with cleer@, the first iteration will show the full URL at all times and have a max height that is 48dp from the top (the minimum touch target).

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f80068e69638cd89296ee95d4253c624ee86f76

commit 5f80068e69638cd89296ee95d4253c624ee86f76
Author: mdjones <mdjones@chromium.org>
Date: Mon Apr 17 20:56:43 2017

[Home] Bottom page info

This change makes the page info popup slide in from the bottom of the
screen when Chrome Home is enabled. Due to some issues with dialogs
auto-animating height changes, the bottom info always shows the full
URL and has a max dialog height set (as opposed to initially
truncating the URL). The max height of the bottom popup is 48dp from
the top of the screen (the minimum touch target). This is only an
issue for excessively long URLs.

BUG= 711096 

Review-Url: https://codereview.chromium.org/2808403008
Cr-Commit-Position: refs/heads/master@{#465013}

[modify] https://crrev.com/5f80068e69638cd89296ee95d4253c624ee86f76/chrome/android/java/src/org/chromium/chrome/browser/page_info/PageInfoPopup.java

Is this "fixed" by patch #4?

Yes; marking as fixed.