New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711093 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

blink_perf.editing broken on chromium.perf

Project Member Reported by martiniss@chromium.org, Apr 12 2017

Issue description

Broken on 12 builders, which is most of the desktop fleet.

An example failure: https://chromium-swarm.appspot.com/task?id=357b803dc9a13110&refresh=10&show_raw=1

Screenshot from that failure: https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-output/o/profiler-file-id_0-2017-04-12_08-01-5170685.png

This benchmark was added very recently in https://chromium-review.googlesource.com/c/451226/. Assigning to the author of that CL.

 
Cc: eakuefner@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ddf0ddf5dc89355220874dc29cc9ca1e3501839

commit 9ddf0ddf5dc89355220874dc29cc9ca1e3501839
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Apr 13 21:38:05 2017

Revert "Add blink_perf.editing"

This reverts commit 0e2585ff6d2ab84636f89e40fb60b2e50263d534.

Reason for revert: failing everywhere on the perf waterfall
BUG= 711093 

Original change's description:
> Add blink_perf.editing
> 
> This was originally reviewed in:
> https://codereview.chromium.org/2729383003/
> And got LGTMs.
> 
> BUG=698661
> 
> Change-Id: Ibddce1f36e86926ae48970ced072de1821dd6ae6
> Reviewed-on: https://chromium-review.googlesource.com/451226
> Commit-Queue: Yoichi Osato <yoichio@chromium.org>
> Reviewed-by: Ned Nguyen <nednguyen@google.com>
> Reviewed-by: Yoichi Osato <yoichio@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#463981}

TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,nednguyen@google.com,telemetry-reviews@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG=698661

Change-Id: I753b0294134a1db7dd3037c1c28c81e6daf8be09
Reviewed-on: https://chromium-review.googlesource.com/476810
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#464554}
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/tools/perf/benchmark.csv
[modify] https://crrev.com/9ddf0ddf5dc89355220874dc29cc9ca1e3501839/tools/perf/benchmarks/blink_perf.py

Status: Fixed (was: Assigned)

Sign in to add a comment