New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711084 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Add channel info to WebView UMA for Monochrome

Project Member Reported by paulmiller@chromium.org, Apr 12 2017

Issue description

so we can implement AwMetricsServiceClientImpl::GetChannel() to report it in UMA.
 

Comment 1 by torne@chromium.org, Apr 13 2017

How would we know which channel it is? We only have a single package and we release the same APK as the previous beta as the stable release.

Comment 2 by sgu...@chromium.org, Apr 13 2017

For N and above, when Monochrome is used, we can get this information, right?

Comment 3 by torne@chromium.org, Apr 13 2017

Oh, yeah; we can do it for monochrome (feed the loaded webview package info into whatever logic chrome uses for this).

Comment 4 by sgu...@chromium.org, Apr 13 2017

Summary: Add channel info to WebView UMA for Monochrome (was: Add channel info to WebView)
Cc: boliu@chromium.org
Labels: -Type-Bug Type-Feature
Status: Assigned (was: Untriaged)
The code for this is here:
https://cs.chromium.org/chromium/src/chrome/common/channel_info_android.cc

Of course we can't use chrome/ from android_webview/. But I don't see a good place to move this. It would be specific to Android, but not to Chrome or WebView. Any ideas?
src/base/android/ might make sense, but I don't know if they'd want info about specific package names under base/.

Comment 7 by boliu@chromium.org, Apr 18 2017

components/crash? or new component?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/234ec23e9f56bb01af5c59922681b114da3aa540

commit 234ec23e9f56bb01af5c59922681b114da3aa540
Author: paulmiller <paulmiller@chromium.org>
Date: Mon Jun 05 23:50:13 2017

WebView: Add channel info for UMA

Inspect the WebView provider package name to determine the channel. This
only works for Monochrome (on Android N+); stand-alone WebView uses the
same package across channels, and will still be reported as "unknown".

Move version_utils from metrics/net/ to metrics/, and move the
channel-checking code from chrome/browser/ to version_info/, so that
WebView can use them.

Split off the part of version_utils that depends on //ui/base, since
most users of version_utils don't need that part, and it pulls in a huge
tree of dependencies.

BUG= 711084 

Review-Url: https://codereview.chromium.org/2879703002
Cr-Commit-Position: refs/heads/master@{#477124}

[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/browser/aw_metrics_service_client.h
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/java/src/org/chromium/android_webview/AwMetricsServiceClient.java
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/common/BUILD.gn
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/common/channel_info.cc
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/common/channel_info_android.cc
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/metrics/BUILD.gn
[rename] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/metrics/version_utils.cc
[rename] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/metrics/version_utils.h
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/sync/BUILD.gn
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/sync/device_info/local_device_info_provider_impl_unittest.cc
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/BUILD.gn
[add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/channel_android.cc
[add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/channel_android.h
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_info.cc
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_info.h
[add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_string.cc
[add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_string.h
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/common/BUILD.gn
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/common/channel_info.mm
[modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/today_extension/today_metrics_logger.mm

Status: Fixed (was: Assigned)
filed https://crbug.com/736949 for fixing the dashboards
Cc: paulmiller@chromium.org michaelbai@chromium.org
 Issue 574226  has been merged into this issue.

Sign in to add a comment