so we can implement AwMetricsServiceClientImpl::GetChannel() to report it in UMA.
How would we know which channel it is? We only have a single package and we release the same APK as the previous beta as the stable release.
For N and above, when Monochrome is used, we can get this information, right?
Oh, yeah; we can do it for monochrome (feed the loaded webview package info into whatever logic chrome uses for this).
The code for this is here: https://cs.chromium.org/chromium/src/chrome/common/channel_info_android.cc Of course we can't use chrome/ from android_webview/. But I don't see a good place to move this. It would be specific to Android, but not to Chrome or WebView. Any ideas?
src/base/android/ might make sense, but I don't know if they'd want info about specific package names under base/.
components/crash? or new component?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/234ec23e9f56bb01af5c59922681b114da3aa540 commit 234ec23e9f56bb01af5c59922681b114da3aa540 Author: paulmiller <paulmiller@chromium.org> Date: Mon Jun 05 23:50:13 2017 WebView: Add channel info for UMA Inspect the WebView provider package name to determine the channel. This only works for Monochrome (on Android N+); stand-alone WebView uses the same package across channels, and will still be reported as "unknown". Move version_utils from metrics/net/ to metrics/, and move the channel-checking code from chrome/browser/ to version_info/, so that WebView can use them. Split off the part of version_utils that depends on //ui/base, since most users of version_utils don't need that part, and it pulls in a huge tree of dependencies. BUG= 711084 Review-Url: https://codereview.chromium.org/2879703002 Cr-Commit-Position: refs/heads/master@{#477124} [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/browser/aw_metrics_service_client.cc [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/browser/aw_metrics_service_client.h [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/android_webview/java/src/org/chromium/android_webview/AwMetricsServiceClient.java [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/browser/metrics/chrome_metrics_service_client.cc [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/common/BUILD.gn [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/common/channel_info.cc [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/chrome/common/channel_info_android.cc [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/metrics/BUILD.gn [rename] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/metrics/version_utils.cc [rename] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/metrics/version_utils.h [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/sync/BUILD.gn [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/sync/device_info/local_device_info_provider_impl_unittest.cc [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/BUILD.gn [add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/channel_android.cc [add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/channel_android.h [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_info.cc [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_info.h [add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_string.cc [add] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/components/version_info/version_string.h [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/browser/metrics/ios_chrome_metrics_service_client.mm [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/common/BUILD.gn [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/common/channel_info.mm [modify] https://crrev.com/234ec23e9f56bb01af5c59922681b114da3aa540/ios/chrome/today_extension/today_metrics_logger.mm
filed https://crbug.com/736949 for fixing the dashboards
Issue 574226 has been merged into this issue.
Comment 1 by torne@chromium.org
, Apr 13 2017