New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711083 link

Starred by 6 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Launch-OWP
Launch-Accessibility: NA
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: NA
Launch-M-Approved: ----
Launch-M-Target: 61-Stable
Launch-Privacy: NA
Launch-Security: Yes
Launch-Test: Yes
Launch-UI: NA
Rollout-Type: ----

Blocking:
issue v8:6785


Participants' hotlists:
Wasm-M59


Sign in to add a comment

WebAssembly Response API support

Project Member Reported by bradnelson@chromium.org, Apr 12 2017

Issue description

Change description:
Adds Response based origin bound variants for WebAssembly compilation and instantiation.

Changes to API surface:
 * Adds WebAssembly.compileStreaming(response)
 * Adds WebAssembly.instantiateStreaming(response)
Where response is always Promise.resolved with the expectation of a Response object (throws TypeError otherwise).

Links:
Proposal agreed on:
https://github.com/WebAssembly/design/blob/master/Web.md

Public standards discussion:
https://github.com/WebAssembly/design/pull/991

Support in other browsers:
Internet Explorer: No
Edge: Public support, but no implementation
Firefox: Public support, but no implementation
Safari: Public support, but no implementation

 
Labels: -M-59 -Launch-M-Target-59-Stable M-60 Launch-M-Target-60-Stable
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1628530d4237e822cd2c3125ab476ea87281d30

commit e1628530d4237e822cd2c3125ab476ea87281d30
Author: Mircea Trofin <mtrofin@chromium.org>
Date: Thu Jul 13 23:17:40 2017

[wasm] Enable Response APIs by default.

Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/T8r1SrZUEZM

Bug:  chromium:711083 
Change-Id: Ieb9c7b3fcf76d6b13ef0c89d676cecf02b0daa78
Reviewed-on: https://chromium-review.googlesource.com/513531
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486524}
[modify] https://crrev.com/e1628530d4237e822cd2c3125ab476ea87281d30/content/public/common/content_features.cc
[modify] https://crrev.com/e1628530d4237e822cd2c3125ab476ea87281d30/third_party/WebKit/LayoutTests/NeverFixTests

Cc: -seththompson@chromium.org nattestad@chromium.org
Labels: -Pri-3 -M-60 -Launch-M-Target-60-Stable M-61 Launch-M-Target-61-Stable Pri-2
Status: Fixed (was: Assigned)
This is only available on Window, not WorkerGlobalScope. Is this correct?
For the moment, yes. In worker cases, the API would have little value until we start exploring transparent caching.
If this API is called and the response fails because of content security policy, the tab crashes (Aw, snap!)
Thanks - what csp is that, so I can try to repro it precisely?

Comment 10 Deleted

Comment 11 Deleted

Test. Why is it deleting messages?
Attaching as text file, because of the dodgy keyword blacklist.
csp.txt
54 bytes View Download
This feature is targeted for M61 Stable and M61 is going to stable next week.  Cross functional bits are either not flipped or missing info. Pls punt this feature to appropriate next milestone.

Owner: nattestad@chromium.org
Thomas, could you please help with the cross-functional bits?
Labels: -Launch-Legal-NotReviewed -Launch-Accessibility-NotReviewed Launch-Accessibility-NA Launch-Legal-NA Launch-Privacy-NA Launch-UI-NA
This feature has no impact on accessibility, legal, privacy, or UI, flipping those bits now to NA 
Labels: Launch-Security-Yes
The security was LGTMed by Jochen in the intent to ship, flipping that bit now 
Labels: Launch-Status-Approval-Requested Launch-Test-Yes
We have tests located here https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/http/tests/wasm_streaming/wasm_response_apis.html?q=wasm_respo&sq=package:chromium&l=1

Flipping test flag now. 
Labels: -Launch-Status-Approval-Requested
Blocking: v8:6785

Sign in to add a comment