Default Search provider on md settings page
Reported by
weaver.j...@gmail.com,
Apr 12 2017
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36 Steps to reproduce the problem: 1. Set the policy to set a default search provider for its use only 2. Go to chrome://settings 3. Also go to chrome://md-settings What is the expected behavior? I have it set to google through policies. They should be both locked from making changes to the default search provider. What went wrong? on the md-settings page, you are allowed to change the default search provider. Did this work before? N/A Chrome version: 57.0.2987.133 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 25.0 r0
,
Apr 18 2017
Thanks for the report. Able to reproduce the issue on Win7 (Client) & Win Server using Stable 57.0.2987.133. chrome://settings - unable to change the default search provider chrome://md-settings - Able to change the default search provider attached screen cast for reference. adding pastarmovj@/blumberg@, could you please check the issue.
,
Apr 24 2017
+dbeam
,
Apr 25 2017
general note: the Material Design settings UI should only be showing to users in Chrome 59 by default. you may have opted into seeing it early, but there are a bunch of bugs in any version before Chrome 59. Chrome is currently on its 60th version on the "Canary" (nightly) channel and I'd advise checking its progress there for the newest, most up-to-date code.
that said: I'm also seeing this bug on newer Chromes (60.0.3078.0, local developer build). I tested with these policy values in a local .json file (on Linux):
{
"DefaultSearchProviderEnabled": true,
"DefaultSearchProviderName": "custom",
"DefaultSearchProviderKeyword": "custom",
"DefaultSearchProviderSearchURL": "https://custom.com/{searchTerms}"
}
this is a bit of a bummer, but it's mainly a visual glitch as far as I can tell. you can't actually change the default search engine away from the one specified by policy (clicking a different option fails to take an effect and is immediately reverted). I just looks like you can :(. it'd be much better if we disabled the input and showed a powerplant icon with an explanation as to why you can't change it.
pastarmovj@: the fix is fairly easy[1], but I'm on the fence as to whether this should be merged to M59.
[1] https://codereview.chromium.org/2835933007
,
Apr 25 2017
another m59 candidate
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e5bf385b3882b6a124ace5495c957e735b5ffcc commit 0e5bf385b3882b6a124ace5495c957e735b5ffcc Author: dbeam <dbeam@chromium.org> Date: Wed Apr 26 22:07:12 2017 MD Settings: show when the default search engine is controlled by policy R=dpapad@chromium.org BUG= 711063 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2835933007 Cr-Commit-Position: refs/heads/master@{#467476} [modify] https://crrev.com/0e5bf385b3882b6a124ace5495c957e735b5ffcc/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/0e5bf385b3882b6a124ace5495c957e735b5ffcc/chrome/browser/resources/settings/search_page/search_page.html [modify] https://crrev.com/0e5bf385b3882b6a124ace5495c957e735b5ffcc/chrome/browser/resources/settings/search_page/search_page.js [modify] https://crrev.com/0e5bf385b3882b6a124ace5495c957e735b5ffcc/chrome/test/data/webui/settings/search_page_test.js
,
Apr 26 2017
,
May 1 2017
,
May 1 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8eb3963a73ceccc041aa3bbc5062b3650d3b2d2 commit f8eb3963a73ceccc041aa3bbc5062b3650d3b2d2 Author: Dan Beam <dbeam@chromium.org> Date: Tue May 02 00:58:06 2017 MD Settings: show when the default search engine is controlled by policy R=dpapad@chromium.org BUG= 711063 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2835933007 Cr-Commit-Position: refs/heads/master@{#467476} (cherry picked from commit 0e5bf385b3882b6a124ace5495c957e735b5ffcc) Review-Url: https://codereview.chromium.org/2851393003 . Cr-Commit-Position: refs/branch-heads/3071@{#337} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/f8eb3963a73ceccc041aa3bbc5062b3650d3b2d2/chrome/browser/extensions/api/settings_private/prefs_util.cc [modify] https://crrev.com/f8eb3963a73ceccc041aa3bbc5062b3650d3b2d2/chrome/browser/resources/settings/search_page/search_page.html [modify] https://crrev.com/f8eb3963a73ceccc041aa3bbc5062b3650d3b2d2/chrome/browser/resources/settings/search_page/search_page.js [modify] https://crrev.com/f8eb3963a73ceccc041aa3bbc5062b3650d3b2d2/chrome/test/data/webui/settings/search_page_test.js
,
May 3 2017
Verified this issue in SkyTap Env "Windows GPO Testing - Beta - A" on Windows 10 with chrome #59.0.3071.36 Observed user is not able to change the default search provider in chrome://md-settings Attaching the screen-cast for reference. Adding TE-Verified labels |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by ligim...@chromium.org
, Apr 12 2017