Payment Request on Desktop - Use correct pluralization of 1 item |
||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Got to https://gauntface.github.io/payment-request-doc-demos/src/ (2) Click on "Run Demo" button under Display Items Example (3) What is the expected result? The UI should read "1 more item" under the display items What happens instead? The UI reads "1 more items" under the display items. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 20 2017
https://codereview.chromium.org/2827293003 fixes this behavior, see attached screenshots.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aaf5884039a25b4f67eec57428e5e61eade2eaf4 commit aaf5884039a25b4f67eec57428e5e61eade2eaf4 Author: anthonyvd <anthonyvd@chromium.org> Date: Thu Apr 20 17:22:07 2017 [Web Payments] Correct pluralization of "more items" BUG= 711058 Review-Url: https://codereview.chromium.org/2827293003 Cr-Commit-Position: refs/heads/master@{#466045} [modify] https://crrev.com/aaf5884039a25b4f67eec57428e5e61eade2eaf4/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/aaf5884039a25b4f67eec57428e5e61eade2eaf4/components/payments_strings.grdp
,
Apr 20 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by anthonyvd@chromium.org
, Apr 20 2017