Payment Request on Desktop Language Support |
|||
Issue descriptionChrome Version: (copy from chrome://version) OS: (e.g. Win7, OSX 10.9.5, etc...) What steps will reproduce the problem? (1) Go to https://gauntface.github.io/payment-request-doc-demos/src/ (2) Click Right to Left Language button What is the expected result? The arabic text to be rendered correctly What happens instead? It's not rendered correctly. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Apr 20 2017
Should be UTF8ToUTF16 instead of ASCIIToUTF16.
,
Apr 20 2017
Can't believe I missed that! Going to do a pass to make sure we use UTF8ToUTF16 everywhere it's relevant.
,
Apr 20 2017
Happens to the best of us ;-)
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/de031ea2c4d1d738d2ac5b8e270af35e1de39bab commit de031ea2c4d1d738d2ac5b8e270af35e1de39bab Author: anthonyvd <anthonyvd@chromium.org> Date: Thu Apr 20 15:51:34 2017 [Web Payments] Correctly use UTF8ToUTF16 on strings from website. BUG= 711057 Review-Url: https://codereview.chromium.org/2830053002 Cr-Commit-Position: refs/heads/master@{#466026} [modify] https://crrev.com/de031ea2c4d1d738d2ac5b8e270af35e1de39bab/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/de031ea2c4d1d738d2ac5b8e270af35e1de39bab/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
,
Apr 20 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by anthonyvd@chromium.org
, Apr 20 2017Status: Assigned (was: Untriaged)