New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711038 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Do not save window state for exo clients that controls its bounds.

Project Member Reported by osh...@chromium.org, Apr 12 2017

Issue description

Since the client controls its own bounds, restore bounds and state, chrome should not save them.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccc903beb67d1ab6d254d0f29d99dfb0da25444d

commit ccc903beb67d1ab6d254d0f29d99dfb0da25444d
Author: oshima <oshima@chromium.org>
Date: Wed Apr 12 23:46:10 2017

Do not save/restore window state for client which controls its own bounds.

BUG= 711038 

Review-Url: https://codereview.chromium.org/2807243007
Cr-Commit-Position: refs/heads/master@{#464208}

[modify] https://crrev.com/ccc903beb67d1ab6d254d0f29d99dfb0da25444d/components/exo/shell_surface.cc
[modify] https://crrev.com/ccc903beb67d1ab6d254d0f29d99dfb0da25444d/components/exo/shell_surface.h

Comment 2 by osh...@chromium.org, Apr 13 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 13 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 11 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-58 Merge-Approved-58
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ba8ec860250f665e290a290e6611cd8a426f865

commit 2ba8ec860250f665e290a290e6611cd8a426f865
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Apr 14 00:39:36 2017

Do not save/restore window state for client which controls its own bounds.

BUG= 711038 

Review-Url: https://codereview.chromium.org/2807243007
Cr-Commit-Position: refs/heads/master@{#464208}
(cherry picked from commit ccc903beb67d1ab6d254d0f29d99dfb0da25444d)

Review-Url: https://codereview.chromium.org/2822643002 .
Cr-Commit-Position: refs/branch-heads/3029@{#703}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/2ba8ec860250f665e290a290e6611cd8a426f865/components/exo/shell_surface.cc
[modify] https://crrev.com/2ba8ec860250f665e290a290e6611cd8a426f865/components/exo/shell_surface.h

Comment 6 by osh...@chromium.org, Apr 17 2017

Status: Fixed (was: Started)

Comment 7 by cda...@chromium.org, May 24 2017

Components: Internals>MUS

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment