New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711030 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 710710



Sign in to add a comment

If the first test step in the build has InfraFailure, no remaining tests are run

Project Member Reported by nedngu...@google.com, Apr 12 2017

Issue description

This is a follow-up from  issue 710710 : "If the first collected swarming task is expired, no remaining swarming tasks are collected"

The cascading failure in the bug was caused by the loop in https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium_tests/api.py?rcl=424fd63dc75bf3fec55f76b98c932621c52577cf&l=286:

      for t in tests:
        try:
          t.run(self._api_for_tests, suffix)
        except self.m.step.InfraFailure:  # pragma: no cover
          raise
        except self.m.step.StepFailure:  # pragma: no cover
          failed_tests.append(t)
          if t.abort_on_failure:
            raise

Based on this code, any InfraFailure of any step will block the whole build, but I don't think we can guarantee a zero percent failure rate for  InfraFailure, especially given any SwarmingFailure will be an InfraFailure (see https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/swarming/api.py?rcl=424fd63dc75bf3fec55f76b98c932621c52577cf&l=668)

I think the loop here should be adjusted so that the build keeps going upon InfraFailure. 

What do other folks think?
 
Components: Infra>Platform>Recipes

Comment 2 by kbr@chromium.org, Apr 13 2017

Blockedon: 710710
It sounds reasonable to me to continue processing of other steps in this case so long as the build ultimately fails due to the infrastructure failure.

Components: Infra>Client>Chrome
Cc: tansell@chromium.org
Components: -Infra>Platform>Recipes Infra>Platform>Swarming
+tansell, not sure if this bug is current, I know you've been working on fixing some of this.
Cc: -serg...@chromium.org
Status: va (was: Untriaged)
Status: Available (was: Va)
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 20 2017

Labels: Hotlist-Google
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 20

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: WontFix (was: Untriaged)
Cc: -phajdan.jr@chromium.org hzl@chromium.org
hzl: if you're marking something as WontFix, please list a reason for doing so.

Sign in to add a comment