New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711008 link

Starred by 1 user
Status: Duplicate
Owner:
jochen@chromium.org
Closed: Apr 2017
Cc:
█ ben@chromium.org
dpranke@chromium.org
dcheng@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

when adding an OWNERS file that covers the entire change, no other owner review is required

Project Member Reported by jochen@chromium.org, Apr 12 2017 
this makes using //OWNERS or //third_party/OWNERS to control the addition of new directories pretty much pointless

Comment 1 by dpranke@chromium.org, Apr 12 2017 

This is actually a dup of the very old bug 141253; this has been the case w/ OWNERS since the beginning :).

Fortunately, dcheng just added a hook to get the previous version of the OWNERS file, and so we could actually fix this if need be.

Comment 2 by jochen@chromium.org, Apr 12 2017 

Ah, cool

My more hacky cl just ignores new files (I assume that this is good enough to catch honest mistakes)

I think we should fix this, otherwise the toplevel owners files are mostly symbolic

Comment 3 by jochen@chromium.org, Apr 13 2017

Cc: dcheng@chromium.org

Comment 4 by jochen@chromium.org, Apr 13 2017

Mergedinto: 141253
Status: Duplicate (was: Assigned)
►

Sign in to add a comment