New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711005 link

Starred by 2 users
Status: Fixed
Owner:
█ joh...@chromium.org
no longer working on chrome
Closed: Dec 2017
Cc:
tedc...@chromium.org
mlamouri@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

VideoFullscreenOrientationLockChromeTest#testUnlockWithDownloadViewerActivity sometimes failing on chromium.android/Lollipop Phone Tester

Project Member Reported by donnd@chromium.org, Apr 12 2017 
I'm seeing an occasional flake of this test on a particular tester: chrome_public_test_apk failing on chromium.android/Lollipop Phone Tester https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=org.chromium.chrome.browser.VideoFullscreenOrientationLockChromeTest%23testUnlockWithDownloadViewerActivity&testType=chrome_public_test_apk

https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11268 shows:

junit.framework.AssertionFailedError: Values did not match. Expected: false, actual: true
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:79)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:94)
	at org.chromium.chrome.browser.VideoFullscreenOrientationLockChromeTest.waitForContentsFullscreenState(VideoFullscreenOrientationLockChromeTest.java:46)
	at org.chromium.chrome.browser.VideoFullscreenOrientationLockChromeTest.testUnlockWithDownloadViewerActivity(VideoFullscreenOrientationLockChromeTest.java:127)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)

Not high priority but slightly bothersome for the Sheriff.
Project Member

Comment 1 by bugdroid1@chromium.org, May 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f9208dc4596ac214ac8d24724c62aa33f84900a

commit 5f9208dc4596ac214ac8d24724c62aa33f84900a
Author: johnme <johnme@chromium.org>
Date: Thu May 04 15:53:20 2017

Mark VideoFullscreenOrientationLockChromeTest to RetryOnFailure

The final waitForContentsFullscreenState(false) occasionally times out,
probably because the KEYCODE_BACK got waylaid by some kind of dialog.
This patch adds @RetryOnFailure in the hopes of working around this.

BUG= 711005 
TBR=mlamouri
NOTRY=true
SKIPTREECHECKS=true

Review-Url: https://codereview.chromium.org/2859243002
Cr-Commit-Position: refs/heads/master@{#469345}

[modify] https://crrev.com/5f9208dc4596ac214ac8d24724c62aa33f84900a/chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java

Comment 2 by joh...@chromium.org, Dec 16 2017 

 Issue 709018  has been merged into this issue.

Comment 3 by joh...@chromium.org, Dec 16 2017

Status: Fixed (was: Assigned)
Seems a lot more reliable now.
►

Sign in to add a comment