New issue
Advanced search Search tips

Issue 710991 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 758456
Owner:
Closed: Sep 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature

Blocking:
issue 511517



Sign in to add a comment

Desktop: Add a mechanism to escape browser fullscreen in Windows 10 Tablet Mode

Project Member Reported by girard@chromium.org, Apr 12 2017

Issue description

Closely related to issue 689157

Splitting out browser fullscreen (found on menu or from F11) from application fullscreen (showing a site like youtube fullscreen)

Doc with some ideas and sketches:
https://docs.google.com/a/chromium.org/document/d/1ruUK3x1KbjmtrzY3rRZuk7hcD7lvRn-a4dWdgtfAT-k/edit?usp=sharing

If you need access, request it from the doc.
 

Comment 1 by girard@chromium.org, Apr 16 2017

Labels: Proj-TabletChrome-Phase1
Description: Show this description
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31ed2f3d8d999b167d949c60c40e22b6c029658f

commit 31ed2f3d8d999b167d949c60c40e22b6c029658f
Author: Robert Liao <robliao@chromium.org>
Date: Fri Jun 30 01:35:27 2017

Experimental Fullscreen Exit Control Prototype

This changelist adds a prototype fullscreen exit control behind the
--enable-fullscreen-exit-ui flag.

BUG= 710991 

Change-Id: I7ea4a224a7b1481327cceb16d00d230d8675e5c7
Reviewed-on: https://chromium-review.googlesource.com/549957
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#483581}
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/app/generated_resources.grd
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/about_flags.cc
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/frame/browser_view.h
[add] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/fullscreen_control/OWNERS
[add] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[add] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h
[add] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.cc
[add] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.h
[add] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view_interactive_uitest.cc
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/common/chrome_switches.cc
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/common/chrome_switches.h
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/chrome/test/BUILD.gn
[modify] https://crrev.com/31ed2f3d8d999b167d949c60c40e22b6c029658f/tools/metrics/histograms/enums.xml

Cc: robliao@chromium.org
Owner: yuweih@chromium.org
Sync'ed up with yuweih, and we both agree that only one dev needs to work on this (he's working on something similar with regards to Esc-lock). He's graciously agreed to pick up this part of the UI as well since it's very similar.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da6615f6582858b679af4016153546adefa300ef

commit da6615f6582858b679af4016153546adefa300ef
Author: Robert Liao <robliao@chromium.org>
Date: Thu Sep 14 01:24:28 2017

Experimental Fullscreen Prototype Refinements

* Changed the button into a circle to see how this feels.
* Moved from ET_GESTURE_LONG_PRESS to ET_GESTURE_LONG_TAP to sync with
  the context menu show and reduce the chance of accidentally
  dismissing the view. It is possible to long press and then
  accidentally trigger a move, accidentally hiding the button.
* Require symmetric show and hide input methods: A touch show can only
  be dismissed by a touch hide. This makes the view robust to spurious
  mouse events from a touch event.

BUG= 710991 

Change-Id: Ib2593e9b5e79d9d9334b11ea60990500f6cd89ca
Reviewed-on: https://chromium-review.googlesource.com/665599
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#501830}
[modify] https://crrev.com/da6615f6582858b679af4016153546adefa300ef/chrome/app/generated_resources.grd
[modify] https://crrev.com/da6615f6582858b679af4016153546adefa300ef/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.cc
[modify] https://crrev.com/da6615f6582858b679af4016153546adefa300ef/chrome/browser/ui/views/fullscreen_control/fullscreen_control_host.h
[modify] https://crrev.com/da6615f6582858b679af4016153546adefa300ef/chrome/browser/ui/views/fullscreen_control/fullscreen_control_view.cc

Comment 6 by yuweih@chromium.org, Sep 15 2017

Mergedinto: 758456
Status: Duplicate (was: Assigned)

Sign in to add a comment