New issue
Advanced search Search tips

Issue 710977 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocked on:
issue 717102



Sign in to add a comment

Implement the design spec for the non-selected states of the payment sheet.

Project Member Reported by anthonyvd@chromium.org, Apr 12 2017

Issue description

The design specs have some buttons and placeholder text on payment sheet rows in some states (no option available/nothing selected).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62

commit 6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62
Author: anthonyvd <anthonyvd@chromium.org>
Date: Fri Apr 14 01:21:16 2017

[Web Payments] Prettify the payment sheet rows in some states.

BUG= 710977 

TBR=bauerb@chromium.org,blundell@chromium.org
(android_chrome_strings.grd, components_strings.grd)

Review-Url: https://codereview.chromium.org/2814173002
Cr-Commit-Position: refs/heads/master@{#464644}

[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/android/java/strings/android_chrome_strings.grd
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_request_item_list.cc
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_request_row_view.cc
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_request_row_view.h
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/chrome/browser/ui/views/payments/payment_sheet_view_controller_browsertest.cc
[modify] https://crrev.com/6f91eb9692b1fbb8839a0dbf9b0f3c5b10117b62/components/components_strings.grd

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 24 2017

Blockedon: 717102
Status: Fixed (was: Assigned)
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment