[Autofill] Be smarter when comparing names in Autofill upstream |
|||
Issue descriptionCurrently we compare credit card / address names in a pretty simple way to determine upstream [1]. Recently, more sophisticated methods were introduced to compare name and their variants [2]. We should consider using those if it makes sense for upstream. Over to Sashi for triage. [1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_manager.cc?rcl=e9b931b5db3e382b208607439ebc22ab0a7e5a68&l=1288 [2] https://cs.chromium.org/chromium/src/components/autofill/core/browser/autofill_profile_comparator.h?rcl=e9b931b5db3e382b208607439ebc22ab0a7e5a68&l=150
,
Apr 27 2017
It's currently not compatible with the server rules; originally I implemented name validation first, and then jdonnelly@ implemented the exact same thing I did but client-side. We did it this way because we wanted to be super cautious about having good, valid data before saving anything to Payments. I'd be interested in looking into this. Name validation is a significant chunk of why Chrome might not offer upload, so if there are more sophisticated methods to check it with confidence, I'm all ears.
,
May 4 2017
Issue 590307 has been merged into this issue.
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7995ddddb7ac652c721c532c7425de58def0147 commit d7995ddddb7ac652c721c532c7425de58def0147 Author: csashi <csashi@google.com> Date: Fri May 05 18:29:39 2017 Uses AutofillProfileComparator to compare profile names. BUG= 710974 Review-Url: https://codereview.chromium.org/2864483005 Cr-Commit-Position: refs/heads/master@{#469731} [modify] https://crrev.com/d7995ddddb7ac652c721c532c7425de58def0147/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/d7995ddddb7ac652c721c532c7425de58def0147/components/autofill/core/browser/autofill_manager_unittest.cc [modify] https://crrev.com/d7995ddddb7ac652c721c532c7425de58def0147/components/autofill/core/browser/autofill_profile_comparator.cc [modify] https://crrev.com/d7995ddddb7ac652c721c532c7425de58def0147/components/autofill/core/browser/autofill_profile_comparator.h
,
May 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9f96db6af2442820fed423f5b1b745bc049ae0ad commit 9f96db6af2442820fed423f5b1b745bc049ae0ad Author: csashi <csashi@google.com> Date: Tue May 09 04:07:55 2017 Adds feature flag to disable AutofillProfileComparator for card name. This will allow us to revert back to previous simpler name comparisons in case Chrome's comparator (incorporated in https://codereview.chromium.org/2864483005/) is more aggressive than payments server. BUG= 710974 Review-Url: https://codereview.chromium.org/2864873002 Cr-Commit-Position: refs/heads/master@{#470182} [modify] https://crrev.com/9f96db6af2442820fed423f5b1b745bc049ae0ad/components/autofill/core/browser/autofill_experiments.cc [modify] https://crrev.com/9f96db6af2442820fed423f5b1b745bc049ae0ad/components/autofill/core/browser/autofill_experiments.h [modify] https://crrev.com/9f96db6af2442820fed423f5b1b745bc049ae0ad/components/autofill/core/browser/autofill_manager.cc [modify] https://crrev.com/9f96db6af2442820fed423f5b1b745bc049ae0ad/components/autofill/core/browser/autofill_manager_unittest.cc
,
May 26 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by csashi@google.com
, Apr 27 2017