Loading Mojofication: Remove unnecessary IPC message construction |
|||||
Issue descriptionURLLoaderClientImpl creates IPC messages unnecessarily. Stop doing that.
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e45a888ffe01954af865afbb1b58020adafd5895 commit e45a888ffe01954af865afbb1b58020adafd5895 Author: yhirano <yhirano@chromium.org> Date: Fri Apr 14 01:24:20 2017 Avoid IPC message creation between URLLoaderClientImpl and ResourceDispatcher Currently we create an IPC message for each URLLoaderClient call for code maintenanceability. This CL stops that for performance. BUG= 710969 Review-Url: https://codereview.chromium.org/2814013004 Cr-Commit-Position: refs/heads/master@{#464646} [modify] https://crrev.com/e45a888ffe01954af865afbb1b58020adafd5895/content/child/url_loader_client_impl.cc [modify] https://crrev.com/e45a888ffe01954af865afbb1b58020adafd5895/content/child/url_loader_client_impl.h [modify] https://crrev.com/e45a888ffe01954af865afbb1b58020adafd5895/content/child/url_response_body_consumer.cc
,
Apr 17 2017
I want to merge e45a888ffe01954af865afbb1b58020adafd5895 to M59 to include the performance improvement in the finch experiment running on beta.
,
Apr 17 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11af3a696c68e52dd21663350f6559f078506329 commit 11af3a696c68e52dd21663350f6559f078506329 Author: Yutaka Hirano <yhirano@chromium.org> Date: Mon Apr 17 01:41:01 2017 Avoid IPC message creation between URLLoaderClientImpl and ResourceDispatcher Currently we create an IPC message for each URLLoaderClient call for code maintenanceability. This CL stops that for performance. BUG= 710969 Review-Url: https://codereview.chromium.org/2814013004 Cr-Commit-Position: refs/heads/master@{#464646} (cherry picked from commit e45a888ffe01954af865afbb1b58020adafd5895) Review-Url: https://codereview.chromium.org/2823803002 . Cr-Commit-Position: refs/branch-heads/3071@{#11} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/11af3a696c68e52dd21663350f6559f078506329/content/child/url_loader_client_impl.cc [modify] https://crrev.com/11af3a696c68e52dd21663350f6559f078506329/content/child/url_loader_client_impl.h [modify] https://crrev.com/11af3a696c68e52dd21663350f6559f078506329/content/child/url_response_body_consumer.cc
,
Apr 17 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yhirano@chromium.org
, Apr 12 2017Labels: -Pri-3 Pri-1
Owner: yhirano@chromium.org
Status: Assigned (was: Asss)