catapult and android_tools have different versions of adb |
|||||||
Issue descriptionLocal Android builds are deployed with this adb, which is placed in the $PATH by build/android/envsetup.sh: third_party/android_tools/sdk/platform-tools/adb # version 1.0.36 But perf benchmarks (tools/perf/run_benchmark) use this adb from catapult: third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb # version 1.0.32 This creates issues with logging, because "adb logcat" disconnects when a different adb starts. A workaround is to invoke catapult's adb explicitly. Is there a reason for these to be different, or could we teach catapult to use the adb from third_party/android_tools?
,
Apr 13 2017
,
Apr 13 2017
In general, we can configure scripts to use a user-supplied version of adb (e.g. https://codesearch.chromium.org/search/?q=adb-path+package:%5Echromium$+file:%5C.py&type=cs). There are two separate issues: 1) run_benchmark is not one of those scripts. I have not looked at how hard it'd be to pipe the option down through telemetry to the point at which it initializes devil (the two devil_env.config.Initialize calls in https://codesearch.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/util/binary_manager.py) 2) devil is still using 1.0.32. I tried upgrading it twice last fall (https://github.com/catapult-project/catapult/commit/49501c0da3481155637169304dfc4a7079bed6fa and https://github.com/catapult-project/catapult/commit/3cf97ee42867b800d8d3a7f33464e62ec11ec4f0). iirc, doing so broke the gpu bots (at least) and I haven't made the time to get back to it yet.
,
Apr 13 2017
Looks like we could just set devil_chromium.json config here... https://cs.chromium.org/chromium/src/tools/perf/chrome_telemetry_build/chromium_config.py?sq=package:chromium&l=34 Not too familiar with the binary dep configs, but I think that would make tools/perf/run_benchmark to use the same adb as everything else?
,
May 4 2017
,
Dec 4 2017
Moving Infra>Client>Android -> Infra>Client>Chrome+OS=Android
,
Dec 4 2017
,
Jan 16
,
Jan 16
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by hzl@chromium.org
, Apr 13 2017