New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710963 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

RemotePlayback.prompt() should reject with NotSupportedError on desktop

Project Member Reported by avayvod@chromium.org, Apr 12 2017

Issue description

I could quick fix it with a check for OS_ANDROID :/
There's no existing plumbing that allows the platform to say it's not implemented, there're just stub empty methods in WebMediaPlayer interface.
 
Could the stub methods somehow reject the promise with the right parameters?
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55fd9698cf58d1f2899a9050c4e143bacdf503a2

commit 55fd9698cf58d1f2899a9050c4e143bacdf503a2
Author: Anton Vayvod <avayvod@google.com>
Date: Fri Jun 02 16:32:47 2017

[RemotePlayback] Disable RemotePlayback backend to save resources.

When using Chrome MediaRouter framework for discovery, each discovery
request would wake the MediaRouteProvider extension at least once per
source. It's better to just disable the backend for now.

This also fixes a bug where we don't resolve prompt() on desktop.

BUG= 710963 ,517102
TEST=run existing tests

Change-Id: I663f4ff007203046e39a4d7151d5bc5c040d9cff
Reviewed-on: https://chromium-review.googlesource.com/518723
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Anton Vayvod <avayvod@chromium.org>
Cr-Commit-Position: refs/heads/master@{#476687}
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/content/child/runtime_features.cc
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/LayoutTests/VirtualTestSuites
[add] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/LayoutTests/media/remoteplayback/prompt-throws-when-backend-disabled.html
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/LayoutTests/media/remoteplayback/prompt-twice-throws.html
[add] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/LayoutTests/media/remoteplayback/util.js
[add] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/LayoutTests/media/remoteplayback/watch-availability-works-when-backend-disabled.html
[add] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/LayoutTests/virtual/new-remote-playback-pipeline/external/wpt/remote-playback/README.txt
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/Source/modules/remoteplayback/RemotePlaybackTest.cpp
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/55fd9698cf58d1f2899a9050c4e143bacdf503a2/third_party/WebKit/public/platform/WebRuntimeFeatures.h

Labels: M-61
Status: Fixed (was: Assigned)
This should be fixed now, at least with chrome://flags#new-remote-playback-pipeline on.

Sign in to add a comment