New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710954 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Task



Sign in to add a comment

Remove VMTests from eve-pre-cq

Project Member Reported by norvez@chromium.org, Apr 12 2017

Issue description


eve-pre-cq fails because the lack of TPM breaks VMTests (login fails, see  Issue 710492 )

ETA for the fix is still unclear and that's blocking all eve-related CLs since the Pre-CQ constantly fails. So at the moment the only way is to chump them which isn't good.

Can we remove VMTests from Eve's Pre-CQ until we have a fix?

Tentatively assigning to infra deputy, sheriffs CC'd
 
Cc: chadversary@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7659817ef39e201f3b7f64aee64db585fbee8a48

commit 7659817ef39e201f3b7f64aee64db585fbee8a48
Author: Nicolas Norvez <norvez@chromium.org>
Date: Thu Apr 27 16:42:37 2017

eve: don't run VMTests in Pre-CQ

Eve images won't run in a VM because they require TPM 2.0. This CL
removes VMTests from the Pre-CQ since they're expected to fail.

BUG= chromium:710954 
BUG= chromium:710492 
TEST=None

Change-Id: If05450ffaf71a82a9dba3fabda0fd7cf5cbb4187
Reviewed-on: https://chromium-review.googlesource.com/477090
Reviewed-by: Dylan Reid <dgreid@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Chad Versace <chadversary@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>

[modify] https://crrev.com/7659817ef39e201f3b7f64aee64db585fbee8a48/overlay-eve/COMMIT-QUEUE.ini

Owner: norvez@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/357c3ed80392d6fbfc9f75f82779dfc1fdf0e1eb

commit 357c3ed80392d6fbfc9f75f82779dfc1fdf0e1eb
Author: Nicolas Norvez <norvez@chromium.org>
Date: Tue May 02 02:18:15 2017

chromeos_config: add eve to cheets boards

eve had not been added to _cheets_x86_boards and the behaviour of the
pre-cq is different. cheets boards do not currently run VMTests
because ARC++ wasn't working in VMs at one point. This has since been
fixed, but other VM-specific issues arise from time to time and it's
confusing why some boards (e.g. reef) do not run VMTests while eve
does.
This CL fixes the inconsistent behaviour between supposedly similar
boards.
Still TODO:
- update the VMTests blacklist with the real reason VMTests don't always
work (not ARC++, likely TPM2)
- remove VMTests from most boards and use dedicated VM builders

BUG= chromium:710492 
BUG= chromium:710954 
TEST=chromeos_config_unittest

Change-Id: I67914956f61eeaee47f79ea65952dba4922d389e
Reviewed-on: https://chromium-review.googlesource.com/490522
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/357c3ed80392d6fbfc9f75f82779dfc1fdf0e1eb/cbuildbot/config_dump.json
[modify] https://crrev.com/357c3ed80392d6fbfc9f75f82779dfc1fdf0e1eb/cbuildbot/waterfall_layout_dump.txt
[modify] https://crrev.com/357c3ed80392d6fbfc9f75f82779dfc1fdf0e1eb/cbuildbot/chromeos_config.py

Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/b6a4235103f0710c40d39c170da04abe0668b0be

commit b6a4235103f0710c40d39c170da04abe0668b0be
Author: Nicolas Norvez <norvez@chromium.org>
Date: Fri May 19 20:57:41 2017

Revert "eve: don't run VMTests in Pre-CQ"

This reverts commit 7659817ef39e201f3b7f64aee64db585fbee8a48.

Reason for revert:
CL:490522 has landed, it makes the eve pre-cq skip VMTests the same way as other similar boards and makes CL:477090 redundant. For consistency and clarity, revert back to the original COMMIT-QEUEUE.ini so all similar boards have the same behaviour (skipping VMTests through config in chromite) and we only have to fix/tweak/change the behaviour in one place.

Original change's description:
> eve: don't run VMTests in Pre-CQ
>
> Eve images won't run in a VM because they require TPM 2.0. This CL
> removes VMTests from the Pre-CQ since they're expected to fail.
>
> BUG= chromium:710954 
> BUG= chromium:710492 
> TEST=None
>
> Change-Id: If05450ffaf71a82a9dba3fabda0fd7cf5cbb4187
> Reviewed-on: https://chromium-review.googlesource.com/477090
> Reviewed-by: Dylan Reid <dgreid@chromium.org>
> Reviewed-by: Ningning Xia <nxia@chromium.org>
> Reviewed-by: Chad Versace <chadversary@chromium.org>
> Tested-by: Nicolas Norvez <norvez@chromium.org>
>

TBR=jrbarnette@chromium.org,dgreid@chromium.org,nxia@chromium.org,norvez@chromium.org,chadversary@chromium.org
# Not skipping CQ checks because original CL landed > 1 day ago.
BUG= chromium:710954 

Change-Id: Id3f7875568c228ac067bfc77b4b32f816e916e89
Reviewed-on: https://chromium-review.googlesource.com/498857
Commit-Ready: Nicolas Norvez <norvez@chromium.org>
Tested-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Nicolas Norvez <norvez@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/b6a4235103f0710c40d39c170da04abe0668b0be/overlay-eve/COMMIT-QUEUE.ini

Comment 6 by norvez@chromium.org, May 22 2017

Status: Fixed (was: Unconfirmed)

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment