Clang use-after-scope failure on windows |
|||
Issue descriptionhttps://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.lkgr%2FWin_ASan_Release%2F4935%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout [344/37298] CXX obj/skia/skia_opts_sse3/SkBitmapProcState_opts_SSSE3.obj FAILED: obj/skia/skia_opts_sse3/SkBitmapProcState_opts_SSSE3.obj C:\b\c\goma_client/gomacc.exe ../../third_party/llvm-build/Release+Asserts/bin/clang-cl.exe /nologo /showIncludes /FC @obj/skia/skia_opts_sse3/SkBitmapProcState_opts_SSSE3.obj.rsp /c ../../third_party/skia/src/opts/SkBitmapProcState_opts_SSSE3.cpp /Foobj/skia/skia_opts_sse3/SkBitmapProcState_opts_SSSE3.obj /Fd"obj/skia/skia_opts_sse3_cc.pdb" clang-cl.exe: error: unknown argument ignored in clang-cl: '-fno-sanitize-address-use-after-scope' [-Werror,-Wunknown-argument] Reid, is this not supported ? Can you disable if not.
,
Apr 12 2017
Should we just dupe this against issue 708707 ? This is just fallout from an attempt to fix that issue. Either way it looks like we need a clang roll to really fix the issue, because Chromium's current clang is enabling ASan use-after-scope checking, and we don't expose a flag to turn it off from clang-cl.
,
Apr 12 2017
+Hans, chromium clang sheriff
,
Apr 12 2017
https://codereview.chromium.org/2813203003/ should fix it for now, although ASan might start finding new use-after-scope bugs on Windows.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f93904f5895990201c1e8df1c13352cba68ceb76 commit f93904f5895990201c1e8df1c13352cba68ceb76 Author: rnk <rnk@chromium.org> Date: Wed Apr 12 19:53:24 2017 Fix Skia WinASan build, remove -fno-sanitize-address-use-after-scope Hopefully Skia doesn't have use-after-scope bugs on Windows, but this will at least fix the build. TBR=hans@chromium.org,krasin@chromium.org,mmoroz@chromium.org BUG= 710928 Review-Url: https://codereview.chromium.org/2813203003 Cr-Commit-Position: refs/heads/master@{#464118} [modify] https://crrev.com/f93904f5895990201c1e8df1c13352cba68ceb76/build/config/sanitizers/BUILD.gn
,
Apr 13 2017
If we roll clang past r300209 we can simplify sanitizers/BUILD.gn by removing some !is_win conditions.
,
May 22 2017
Clang has rolled past that point. Reid, can you please remove the !is_win conditions.
,
May 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/969478f127f1aff63d6bc934b0b11ee2d4703c64 commit 969478f127f1aff63d6bc934b0b11ee2d4703c64 Author: rnk <rnk@chromium.org> Date: Tue May 23 20:13:20 2017 Use -fsanitize-address-use-after-scope on Windows Chromium's clang is new enough to understand this flag now. BUG= 710928 R=mmoroz@chromium.org Review-Url: https://codereview.chromium.org/2899813002 Cr-Commit-Position: refs/heads/master@{#474024} [modify] https://crrev.com/969478f127f1aff63d6bc934b0b11ee2d4703c64/build/config/sanitizers/BUILD.gn
,
May 23 2017
Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by r...@chromium.org
, Apr 12 2017