[Android O] Re-initialize notification channels on locale change |
||||||||
Issue descriptionWe'll need to recreate them for the new channel names to be picked up. See https://docs.google.com/document/d/1K9pjvlHF1oANNI8TqZgy151tap9zs1KUr2qfBXo1s_4/edit# for context. We'll need a broadcast receiver that listens to the LOCALE_CHANGED broadcast and calls ChannelsInitializer.initializeStartupChannels whenever it occurs
,
Apr 13 2018
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 25 2018
Re-assigning to awdf@
,
Apr 25 2018
,
Aug 2
,
Aug 2
,
Oct 23
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ebdd6a6c09fb8c4562e7931c5a17fb17673edbbc commit ebdd6a6c09fb8c4562e7931c5a17fb17673edbbc Author: Richard Knoll <knollr@chromium.org> Date: Fri Nov 02 11:08:48 2018 refactor: allow passing multiple channels to init This allows us to only init channel groups once, instead of multiple times, when initializing channels. Bug: 710925 Change-Id: Icb00711eb9a5c204699b73084daa3791f96740da Reviewed-on: https://chromium-review.googlesource.com/c/1304515 Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#604885} [modify] https://crrev.com/ebdd6a6c09fb8c4562e7931c5a17fb17673edbbc/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializer.java [modify] https://crrev.com/ebdd6a6c09fb8c4562e7931c5a17fb17673edbbc/chrome/android/javatests/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializerTest.java
,
Nov 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8b97e2b522c5f8d478f9ee4aceb0d6467189f830 commit 8b97e2b522c5f8d478f9ee4aceb0d6467189f830 Author: Richard Knoll <knollr@chromium.org> Date: Fri Nov 02 11:20:36 2018 fix: update channels on locale change Bug: 710925 Change-Id: I357c105c1aa40b0acca41edde0423141fb6f62c0 Reviewed-on: https://chromium-review.googlesource.com/c/1304793 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#604887} [modify] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/chrome/android/java/AndroidManifest.xml [add] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleChangedBroadcastReceiver.java [modify] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelsInitializer.java [modify] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/chrome/android/java/src/org/chromium/chrome/browser/notifications/channels/ChannelsUpdater.java [modify] https://crrev.com/8b97e2b522c5f8d478f9ee4aceb0d6467189f830/chrome/android/java_sources.gni
,
Nov 5
Fixed after https://bugs.chromium.org/p/chromium/issues/detail?id=901840 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by awdf@chromium.org
, Apr 12 2017