New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710917 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Disable Default Touch Bar

Project Member Reported by spqc...@chromium.org, Apr 12 2017

Issue description

The Default Touch Bar isn't ready to ship for M58. This needs to be disabled


 
Labels: M-58
Components: UI>Browser>Touchbar
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c043081029a5b1ecee573c50c5fa21aa4bd956b7

commit c043081029a5b1ecee573c50c5fa21aa4bd956b7
Author: spqchan <spqchan@chromium.org>
Date: Wed Apr 12 19:38:42 2017

Disable the Touch Bar

BUG= 710917 

Review-Url: https://codereview.chromium.org/2807243006
Cr-Commit-Position: refs/heads/master@{#464112}

[modify] https://crrev.com/c043081029a5b1ecee573c50c5fa21aa4bd956b7/chrome/common/chrome_features.cc

Labels: Merge-Request-58
Need to bake to Canary first...
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 12 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 12 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by gov...@chromium.org, Apr 12 2017

Pls apply appropriate OSs label.
Labels: OS-Mac

Comment 8 by shrike@chromium.org, Apr 13 2017

Labels: ReleaseBlock-Stable
FYI: M58 stable promotion is scheduled next week and RC cut on Monday 04/17, 4.00 PM PST/
How is this change looking in Canary? 
Looking good
Labels: -Merge-Review-58 Merge-Approved-58
Great thanks, approving revision: https://chromium.googlesource.com/chromium/src.git/+/c043081029a5b1ecee573c50c5fa21aa4bd956b7 for M58 Merge.
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 13 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff34361963761f7811760b57f299db9f697751c5

commit ff34361963761f7811760b57f299db9f697751c5
Author: spqchan <spqchan@chromium.org>
Date: Thu Apr 13 21:47:55 2017

Disable the Touch Bar

BUG= 710917 

Review-Url: https://codereview.chromium.org/2807243006
Cr-Commit-Position: refs/heads/master@{#464112}
(cherry picked from commit c043081029a5b1ecee573c50c5fa21aa4bd956b7)

Review-Url: https://codereview.chromium.org/2818863002 .
Cr-Commit-Position: refs/branch-heads/3029@{#699}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/ff34361963761f7811760b57f299db9f697751c5/chrome/common/chrome_features.cc

Status: Fixed (was: Started)

Sign in to add a comment