New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710916 link

Starred by 1 user
Status: Fixed
Owner:
█ dschuyler@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
█ scottchen@chromium.org
█ dschuyler@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[General] Adjust alignment of sliders

Project Member Reported by bettes@chromium.org, Apr 12 2017 
Update the alignment for sliders in MD-settings to better align with toggles and indicators. 

As of today, they're too far to the left.

Comment 1 by bettes@chromium.org, Apr 12 2017

image (28).png
374 KB View Download

Comment 2 by dbeam@chromium.org, Apr 17 2017

Cc: dschuyler@chromium.org steve...@chromium.org scottchen@chromium.org
Status: Available (was: Untriaged)
not sure, but this probably affects desktop, too.

Comment 3 by dschuyler@chromium.org, Apr 18 2017

Owner: dschuyler@chromium.org
Status: Assigned (was: Available)
@#2 Yeah, it appears so. I tried an April 10th build and it was incorrect there.

Comment 4 by dschuyler@chromium.org, Apr 18 2017

Status: Started (was: Assigned)

Comment 5 by dschuyler@chromium.org, Apr 18 2017

Labels: Pri-2 Type-Bug-Regression
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/17b99ff033da165b9cb52dc6d611e1da28b07b81

commit 17b99ff033da165b9cb52dc6d611e1da28b07b81
Author: dschuyler <dschuyler@chromium.org>
Date: Tue Apr 18 20:59:49 2017

[MD settings] align sliders with margin

This CL moves the slider controls toward the end of the line so that
they visually align with the right-hand margin.

BUG= 710916 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2823143002
Cr-Commit-Position: refs/heads/master@{#465369}

[modify] https://crrev.com/17b99ff033da165b9cb52dc6d611e1da28b07b81/chrome/browser/resources/settings/controls/settings_slider.html

Comment 7 by dschuyler@chromium.org, Apr 18 2017

Status: Fixed (was: Started)
►

Sign in to add a comment