Issue metadata
Sign in to add a comment
|
SuggestionsBottomSheetTest#testContextMenu failing on multiple bots |
||||||||||||||||||||
Issue descriptionSeeing several failures of SuggestionsBottomSheetTest#testContextMenu e.g. chrome_public_test_apk failing on chromium.android/Lollipop Phone Tester Builders failed on: - Lollipop Phone Tester: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester Failure from https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FLollipop_Phone_Tester%2F11265%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Fstdout C 789.262s Main [FAIL] org.chromium.chrome.browser.suggestions.SuggestionsBottomSheetTest#testContextMenu: C 789.262s Main junit.framework.AssertionFailedError C 789.262s Main at org.chromium.chrome.browser.suggestions.SuggestionsBottomSheetTest.testContextMenu(SuggestionsBottomSheetTest.java:60) C 789.262s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 789.262s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 789.262s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 789.262s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758) C 789.262s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 789.262s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 789.262s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 789.262s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 789.262s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 789.262s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853) Matt or Theresa any guesses about recent changes that might have caused this or potential authors?
,
Apr 12 2017
Nicolas, do you have a guess as to whether this can be easily fixed, or should I just revert?
,
Apr 12 2017
Yes it should not be hard to fix. Looking.
,
Apr 12 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bda5d3a105bda1fe84dccf5d0bccb1f5e33b077 commit 3bda5d3a105bda1fe84dccf5d0bccb1f5e33b077 Author: dgn <dgn@chromium.org> Date: Wed Apr 12 19:35:25 2017 [Home] Fix SuggestionsBottomSheetTest#testContextMenu The touch disabled view is the bottom sheet itself rather than the recycler view after https://codereview.chromium.org/2810713002 landed, so the test should have been updated. BUG= 710912 Review-Url: https://codereview.chromium.org/2814073003 Cr-Commit-Position: refs/heads/master@{#464110} [modify] https://crrev.com/3bda5d3a105bda1fe84dccf5d0bccb1f5e33b077/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java
,
Apr 12 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by donnd@chromium.org
, Apr 12 2017Owner: mvanouwe...@chromium.org
Status: Assigned