I'm seeing a few failures in chrome_public_test_apk failing on chromium.android/Marshmallow Tablet Tester. I suspect https://codereview.chromium.org/2812893002 Builders failed on: - Marshmallow Tablet Tester: https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester Parastoo, PTL! Dan or Mathieu, you reviewed, do you think we should revert again, or maybe there's a simple fix for this?
Hi Donn, since Parastoo is in training I think it's probably safe to revert and fix this with no time pressure. Would you like to do it?
It was reverted once for similar reasons, makes sense to revert it again.
Reverting (https://codereview.chromium.org/2817733002/ in progress)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090 commit 5e3734d5c1970621238dc4b5fa3d47a8fdd0b090 Author: parastoog <parastoog@google.com> Date: Tue May 09 04:48:26 2017 Reland explanation: crrev.com/2812893002 caused chrome_public_test_apk failing on chromium.android/Marshmallow. The problem is fixed in this CL. Note: To make the payment request tests independent of the network status, the tests set the time-out = 0, which means that the sub-keys must never be fetched, and the address forms will always show a textfield, and not a dropdown for the admin areas. Problem with the previous CL: The function: Handler().PostDelayed receives the time-out, but may add an additional delay to that. Therefore, sometimes, even if the time-out is set to 0, the sub-keys get fetched. Solution: To solve this problem, the case for time-out = 0 is checked at first, and the call to the function PostDelayed is skipped if the condition holds. BUG= 710911 Review-Url: https://codereview.chromium.org/2866643004 Cr-Commit-Position: refs/heads/master@{#470225} [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/payments/AddressEditor.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorDropdownField.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorView.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileBridge.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/browser/autofill/android/personal_data_manager_android.cc [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/chrome/browser/autofill/android/personal_data_manager_android.h [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/third_party/libaddressinput/chromium/chrome_address_validator.cc [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/third_party/libaddressinput/chromium/chrome_address_validator.h [modify] https://crrev.com/5e3734d5c1970621238dc4b5fa3d47a8fdd0b090/third_party/libaddressinput/chromium/chrome_address_validator_unittest.cc
parastoog@ this is fixed now, right?
Comment 1 by ma...@chromium.org
, Apr 12 2017