New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 710906 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 516866


Show other hotlists

Hotlists containing this issue:
Hotlist-1


Sign in to add a comment

BookmarkDataTypeController relies on EXPLICIT_ACCESS

Project Member Reported by s...@chromium.org, Apr 12 2017

Issue description

I tried to update ChromeSyncClient's retrieval of the HistoryService from EXPLICIT_ACCESS to IMPLICIT_ACCESS in https://codereview.chromium.org/2769113002. This change was ultimately rolled back, but one ramification is when history is forced off by kSavingBrowserHistoryDisabled, the BookmarkDataTypeController's bizarre handling of receiving a nullptr for HistoryService resulted in a crash on ChromeOS, see issue 709610.

It asks for the HistoryService (in addition to BookmarkModel), and if it's null or not loaded, adds an observer. However, if it was null, this adding of an observer is going to crash. The only reason it used to be safe is that with the EXPLICIT_ACCESS, it never received a nullptr. The ProfileSyncServiceFactory depends on HistoryService, so if it is going to be created, it should already have been created.

 

Comment 1 by s...@chromium.org, Jan 17 2018

Labels: SyncHandoff2018
Owner: mastiz@chromium.org
Status: Assigned (was: Available)
This should be addressed as part of converting BOOKMARKS to USS.
Owner: mamir@chromium.org
Blockedon: 516866

Sign in to add a comment