Issue metadata
Sign in to add a comment
|
Tests failing with "AccountManagerHelper is not initialized" |
||||||||||||||||||||
Issue descriptionThere are multiple recent failures that seem to be due to a recently landed refactoring: https://codereview.chromium.org/2747293005 See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testClearingEverything which shows browser_side_navigation_chrome_public_test_apk failing on chromium.android/Marshmallow 64 bit Tester and several others. Tommy, since you reviewed this CL, do you want to take a quick look to see if the problem can be fixed, or should I just revert? -- Sheriff DonnD@
,
Apr 12 2017
Got the OK to revert https://codereview.chromium.org/2747293005 from the author, will do so now.
,
Apr 12 2017
Failures from this log (https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FMarshmallow_64_bit_Tester%2F11155%2F%2B%2Frecipes%2Fsteps%2Fchrome_public_test_apk_on_Android%2F0%2Fstdout): I 909.526s Main 4 failed tests remain. C 909.538s Main ******************************************************************************** C 909.538s Main Detailed Logs C 909.539s Main ******************************************************************************** C 909.541s Main [FAIL] org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testClearingEverything: C 909.541s Main java.lang.AssertionError: AccountManagerHelper is not initialized! C 909.541s Main at org.chromium.components.signin.AccountManagerHelper.get(AccountManagerHelper.java:103) C 909.541s Main at org.chromium.chrome.browser.signin.AccountTrackerService.validateSystemAccounts(AccountTrackerService.java:202) C 909.541s Main at org.chromium.chrome.browser.signin.SigninHelper.validateAccountSettings(SigninHelper.java:133) C 909.541s Main at org.chromium.chrome.browser.services.GoogleServicesManager.onMainActivityStart(GoogleServicesManager.java:105) C 909.541s Main at org.chromium.chrome.browser.services.GoogleServicesManager.onApplicationStateChange(GoogleServicesManager.java:114) C 909.541s Main at org.chromium.base.ApplicationStatus.onStateChange(ApplicationStatus.java:229) C 909.541s Main at org.chromium.base.ApplicationStatus.access$100(ApplicationStatus.java:30) C 909.541s Main at org.chromium.base.ApplicationStatus$2.onActivityStarted(ApplicationStatus.java:161) C 909.541s Main at android.app.Application.dispatchActivityStarted(Application.java:205) C 909.542s Main at android.app.Activity.onStart(Activity.java:1150) C 909.542s Main at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:595) C 909.542s Main at android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:181) C 909.542s Main at org.chromium.chrome.browser.init.AsyncInitializationActivity.onStart(AsyncInitializationActivity.java:308) C 909.542s Main at org.chromium.chrome.browser.ChromeActivity.onStart(ChromeActivity.java:993) C 909.542s Main at org.chromium.chrome.browser.ChromeTabbedActivity.onStart(ChromeTabbedActivity.java:552) C 909.542s Main at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1237) C 909.542s Main at android.app.Activity.performStart(Activity.java:6268) C 909.542s Main at android.app.Activity.performRestart(Activity.java:6314) C 909.542s Main at android.app.Activity.performResume(Activity.java:6319) C 909.542s Main at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3092) C 909.542s Main at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3134) C 909.542s Main at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1388) C 909.542s Main at android.os.Handler.dispatchMessage(Handler.java:102) C 909.542s Main at android.os.Looper.loop(Looper.java:148) C 909.542s Main at android.app.ActivityThread.main(ActivityThread.java:5417) C 909.542s Main at java.lang.reflect.Method.invoke(Native Method) C 909.542s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) C 909.542s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) C 909.542s Main C 909.542s Main [FAIL] org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testClearingHistoryClearsWebappScopesAndLaunchTimes: C 909.542s Main java.lang.AssertionError: AccountManagerHelper is not initialized! C 909.542s Main at org.chromium.components.signin.AccountManagerHelper.get(AccountManagerHelper.java:103) C 909.542s Main at org.chromium.chrome.browser.signin.AccountTrackerService.validateSystemAccounts(AccountTrackerService.java:202) C 909.542s Main at org.chromium.chrome.browser.signin.SigninHelper.validateAccountSettings(SigninHelper.java:133) C 909.542s Main at org.chromium.chrome.browser.services.GoogleServicesManager.onMainActivityStart(GoogleServicesManager.java:105) C 909.542s Main at org.chromium.chrome.browser.services.GoogleServicesManager.onApplicationStateChange(GoogleServicesManager.java:114) C 909.542s Main at org.chromium.base.ApplicationStatus.onStateChange(ApplicationStatus.java:229) C 909.542s Main at org.chromium.base.ApplicationStatus.access$100(ApplicationStatus.java:30) C 909.542s Main at org.chromium.base.ApplicationStatus$2.onActivityStarted(ApplicationStatus.java:161) C 909.542s Main at android.app.Application.dispatchActivityStarted(Application.java:205) C 909.542s Main at android.app.Activity.onStart(Activity.java:1150) C 909.542s Main at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:595) C 909.542s Main at android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:181) C 909.542s Main at org.chromium.chrome.browser.init.AsyncInitializationActivity.onStart(AsyncInitializationActivity.java:308) C 909.542s Main at org.chromium.chrome.browser.ChromeActivity.onStart(ChromeActivity.java:993) C 909.542s Main at org.chromium.chrome.browser.ChromeTabbedActivity.onStart(ChromeTabbedActivity.java:552) C 909.542s Main at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1237) C 909.542s Main at android.app.Activity.performStart(Activity.java:6268) C 909.542s Main at android.app.Activity.performRestart(Activity.java:6314) C 909.542s Main at android.app.Activity.performResume(Activity.java:6319) C 909.542s Main at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3092) C 909.542s Main at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3134) C 909.542s Main at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1388) C 909.542s Main at android.os.Handler.dispatchMessage(Handler.java:102) C 909.542s Main at android.os.Looper.loop(Looper.java:148) C 909.542s Main at android.app.ActivityThread.main(ActivityThread.java:5417) C 909.542s Main at java.lang.reflect.Method.invoke(Native Method) C 909.542s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) C 909.542s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) C 909.542s Main C 909.542s Main [FAIL] org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferencesTest#testClearingSiteDataClearsWebapps: C 909.542s Main java.lang.AssertionError: AccountManagerHelper is not initialized! C 909.542s Main at org.chromium.components.signin.AccountManagerHelper.get(AccountManagerHelper.java:103) C 909.542s Main at org.chromium.chrome.browser.signin.AccountTrackerService.validateSystemAccounts(AccountTrackerService.java:202) C 909.542s Main at org.chromium.chrome.browser.signin.SigninHelper.validateAccountSettings(SigninHelper.java:133) C 909.542s Main at org.chromium.chrome.browser.services.GoogleServicesManager.onMainActivityStart(GoogleServicesManager.java:105) C 909.543s Main at org.chromium.chrome.browser.services.GoogleServicesManager.onApplicationStateChange(GoogleServicesManager.java:114) C 909.543s Main at org.chromium.base.ApplicationStatus.onStateChange(ApplicationStatus.java:229) C 909.543s Main at org.chromium.base.ApplicationStatus.access$100(ApplicationStatus.java:30) C 909.543s Main at org.chromium.base.ApplicationStatus$2.onActivityStarted(ApplicationStatus.java:161) C 909.543s Main at android.app.Application.dispatchActivityStarted(Application.java:205) C 909.543s Main at android.app.Activity.onStart(Activity.java:1150) C 909.543s Main at android.support.v4.app.FragmentActivity.onStart(FragmentActivity.java:595) C 909.543s Main at android.support.v7.app.AppCompatActivity.onStart(AppCompatActivity.java:181) C 909.543s Main at org.chromium.chrome.browser.init.AsyncInitializationActivity.onStart(AsyncInitializationActivity.java:308) C 909.543s Main at org.chromium.chrome.browser.ChromeActivity.onStart(ChromeActivity.java:993) C 909.543s Main at org.chromium.chrome.browser.ChromeTabbedActivity.onStart(ChromeTabbedActivity.java:552) C 909.543s Main at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1237) C 909.543s Main at android.app.Activity.performStart(Activity.java:6268) C 909.543s Main at android.app.Activity.performRestart(Activity.java:6314) C 909.543s Main at android.app.Activity.performResume(Activity.java:6319) C 909.543s Main at android.app.ActivityThread.performResumeActivity(ActivityThread.java:3092) C 909.543s Main at android.app.ActivityThread.handleResumeActivity(ActivityThread.java:3134) C 909.543s Main at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1388) C 909.543s Main at android.os.Handler.dispatchMessage(Handler.java:102) C 909.543s Main at android.os.Looper.loop(Looper.java:148) C 909.543s Main at android.app.ActivityThread.main(ActivityThread.java:5417) C 909.543s Main at java.lang.reflect.Method.invoke(Native Method) C 909.543s Main at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) C 909.543s Main at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) C 909.543s Main C 909.543s Main [FAIL] org.chromium.chrome.browser.suggestions.SuggestionsBottomSheetTest#testContextMenu: C 909.543s Main junit.framework.AssertionFailedError C 909.543s Main at org.chromium.chrome.browser.suggestions.SuggestionsBottomSheetTest.testContextMenu(SuggestionsBottomSheetTest.java:60) C 909.543s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214) C 909.543s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199) C 909.543s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192) C 909.543s Main at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:758) C 909.543s Main at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161) C 909.543s Main at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124) C 909.543s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191) C 909.543s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176) C 909.543s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555) C 909.543s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)
,
Apr 12 2017
Reverted the problem CL.
,
Apr 26 2017
Links to failed bots: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/11259 https://build.chromium.org/p/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/11146 It looks like my CL caused failures in ClearBrowsingDataPreferencesTest only. Error in SuggestionsBottomSheetTest doesn't seem to be connected to my changes and is probably transient (I can't reproduce on TOT). Going to reland my CL with fixes for ClearBrowsingDataPreferencesTest.
,
Apr 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c613e1f102863081348db126d8db74fc11e389fb commit c613e1f102863081348db126d8db74fc11e389fb Author: bsazonov <bsazonov@chromium.org> Date: Thu Apr 27 07:42:35 2017 Reland of Reimplement AccountManagerHelper singleton instance creation Original CL: http://crrev.com/2747293005 Current implementation of AccountManagerHelper can instantiate wrong delegate type if get() is called in too early. This CL fixes it. AtomicReference is used to avoid relying on external synchronization, because get() can be called from different threads. This CL also adds AccountManagerHelper.resetAccountManagerHelperForTests method that makes sure there's no interference between tests. BUG=698258, 710901 TBR=rogerta@chromium.org Review-Url: https://codereview.chromium.org/2836373003 Cr-Commit-Position: refs/heads/master@{#467619} [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/history/HistoryActivityTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PasswordViewingTypeTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferencesTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninHelperTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/signin/SigninTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/javatests/src/org/chromium/chrome/browser/util/FeatureUtilitiesTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/junit/src/org/chromium/chrome/browser/superviseduser/SupervisedUserContentProviderUnitTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/account_tracker_service_unittest.cc [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/android/java/src/org/chromium/components/signin/AccountManagerHelper.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/android/java/src/org/chromium/components/signin/ChildAccountInfoFetcher.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/android/javatests/src/org/chromium/components/signin/test/AccountManagerHelperTest.java [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/child_account_info_fetcher.cc [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/child_account_info_fetcher.h [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/child_account_info_fetcher_android.cc [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/signin/core/browser/child_account_info_fetcher_android.h [modify] https://crrev.com/c613e1f102863081348db126d8db74fc11e389fb/components/sync/android/javatests/src/org/chromium/components/sync/AndroidSyncSettingsTest.java
,
May 3 2017
Re-opening, as the re-landed CL (https://codereview.chromium.org/2836373003) caused SyncCustomizationFragmentTest#testPassphraseCreation to start flakily crashing. See: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_sync_shell_test_apk&tests=SyncCustomizationFragmentTest%23testPassphraseCreation The first failing build is https://build.chromium.org/p/chromium.android/builders/Lollipop%20Tablet%20Tester/builds/7715. The retry passed, but you can see the crash under chrome_sync_shell_test_apk > Nested step(s) > result details[1], then click on org.chromium.chrome.browser.sync.SyncCustomizationFragmentTest and it'll give you the logcat[2] and tombstones[3]. https://codereview.chromium.org/2836373003 isn't on the blamelist for that build, but it is on the blamelist for the previous build, and there's nothing else that looks relevant. bsazonov@, could you look into this, and revert or fix? Thanks! [1]: https://storage.cloud.google.com/chromium-result-details/html/chrome_sync_shell_test_apk_Lollipop%20Tablet%20Tester_7715_2017_04_27_T04_36_35.html [2]: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FLollipop_Tablet_Tester%2F7715%2F%2B%2Flogcat_org.chromium.chrome.browser.sync.SyncCustomizationFragmentTest.testPassphraseCreation_20170427T043606_0a084b87 [3]: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.android%2FLollipop_Tablet_Tester%2F7715%2F%2B%2Ftombstones_20170427T043618_0a084b87 The tombstones shows: [FATAL:jni_android.cc(243)] Please include Java exception stack in crash report Java stderr from crashing pid (may identify underlying Java exception): at java.lang.reflect.Method.invoke(Native Method) at java.lang.reflect.Method.invoke(Method.java:372) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) java.lang.AssertionError: AccountManagerHelper is not initialized! at org.chromium.components.signin.AccountManagerHelper.get(AccountManagerHelper.java:103) at org.chromium.chrome.browser.signin.OAuth2TokenService.hasOAuth2RefreshToken(OAuth2TokenService.java:230) at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:41) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:135) at android.app.ActivityThread.main(ActivityThread.java:5254) at java.lang.reflect.Method.invoke(Native Method) at java.lang.reflect.Method.invoke(Method.java:372) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698)
,
May 3 2017
,
May 3 2017
Assertion failure actually happens _after_ test execution. It looks like some code still runs after tearDown() call: E/cr_ZOMGTEHDRAMA(30420): tearDown start ..... logs, logs, logs E/cr_ZOMGTEHDRAMA(30420): tearDown end I/TestRunner(30420): finished: testPassphraseCreation(org.chromium.chrome.browser.sync.SyncCustomizationFragmentTest) I/TestRunner(30420): passed: testPassphraseCreation(org.chromium.chrome.browser.sync.SyncCustomizationFragmentTest) D/AndroidRuntime(30374): Shutting down VM W/cr_BaseChildProcessConn(30420): onServiceDisconnected (crash or killed by oom): pid=30463 W/System.err(30420): java.lang.AssertionError: AccountManagerHelper is not initialized! W/System.err(30420): at org.chromium.components.signin.AccountManagerHelper.get(AccountManagerHelper.java:99) W/System.err(30420): at org.chromium.chrome.browser.signin.OAuth2TokenService.hasOAuth2RefreshToken(OAuth2TokenService.java:230) W/System.err(30420): at org.chromium.base.SystemMessageHandler.nativeDoRunLoopOnce(Native Method) W/System.err(30420): at org.chromium.base.SystemMessageHandler.handleMessage(SystemMessageHandler.java:41) W/System.err(30420): at android.os.Handler.dispatchMessage(Handler.java:102) W/System.err(30420): at android.os.Looper.loop(Looper.java:135) W/System.err(30420): at android.app.ActivityThread.main(ActivityThread.java:5254) W/System.err(30420): at java.lang.reflect.Method.invoke(Native Method) W/System.err(30420): at java.lang.reflect.Method.invoke(Method.java:372) W/System.err(30420): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:903) W/System.err(30420): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:698) F/chromium(30420): [FATAL:jni_android.cc(243)] Please include Java exception stack in crash report Stack Trace: 00093cd3 base::debug::StackTrace::StackTrace() 000a9bcd logging::LogMessage::~LogMessage() 0008119d base::android::CheckException(_JNIEnv*) v------> jni_generator::CheckException(_JNIEnv*) v------> Java_OAuth2TokenService_hasOAuth2RefreshToken 00609229 OAuth2TokenServiceDelegateAndroid::RefreshTokenIsAvailable(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) const 004e419b ProfileDownloader::StartForAccount(std::__ndk1::basic_string<char, std::__ndk1::char_traits<char>, std::__ndk1::allocator<char> > const&) 004e31d9 ProfileDownloader::Start() v------> base::Callback<void (), (base::internal::CopyMode)1, (base::internal::RepeatMode)1>::Run() const & 000f7b0f base::Timer::RunScheduledTask() v------> base::Callback<void (), (base::internal::CopyMode)0, (base::internal::RepeatMode)0>::Run() && 00094697 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) 000b0ce5 base::MessageLoop::RunTask(base::PendingTask*) 000b114b base::MessageLoop::DeferOrRunPendingTask(base::PendingTask) 000b18eb base::MessageLoop::DoDelayedWork(base::TimeTicks*) 000b2f41 DoRunLoopOnce 000b3023 Java_org_chromium_base_SystemMessageHandler_nativeDoRunLoopOnce I'm not sure whether it is the expected behavior for ChromeActivityTestCaseBase. I've created CL to remove resetAccountManagerHelperForTests() call from SigninTestUtil.tearDownAuthForTest: https://codereview.chromium.org/2858033002. This call was added as a safety net to make sure there's no interference between the tests, so it's not a big deal. It should fix test failures.
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/13ff380516dc3522023bc43a5d260b8520f42cd5 commit 13ff380516dc3522023bc43a5d260b8520f42cd5 Author: bsazonov <bsazonov@chromium.org> Date: Wed May 03 19:48:27 2017 Remove resetAccountManagerHelperForTests() since it caused test failures This CL removes resetAccountManagerHelperForTests() call from SigninTestUtil. BUG= 710901 TBR=nyquist@chromium.org Review-Url: https://codereview.chromium.org/2858033002 Cr-Commit-Position: refs/heads/master@{#469083} [modify] https://crrev.com/13ff380516dc3522023bc43a5d260b8520f42cd5/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/signin/SigninTestUtil.java
,
May 4 2017
I've fixed failing test by removing resetAccountManagerHelperForTests(), so bumping down priority. I've also started an email thread to find proper way resolve this (and similar) issues.
,
May 9 2017
Strange behavior described in #c9 was caused by a bug that was introduced during JUnit4 conversion (see issue 718454 ). However, it makes sense to take another look at resetAccountManagerHelperForTests() to keep it consistent with refactoring work tracked in issue 698258, so I'll leave this bug open (with lower priority).
,
May 12 2017
This is still happening for me locally when running DownloadManagerServiceTest.
,
May 18 2017
I'll take this one, I have a fix for the AccountManagerHelper initialization failure.
,
May 18 2017
,
Jun 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c9874f171dcdc89467c07d06b5a0d99316cbbad commit 9c9874f171dcdc89467c07d06b5a0d99316cbbad Author: thildebr <thildebr@chromium.org> Date: Tue Jun 13 18:43:44 2017 Fix crashing TabPersistentStoreTest. Migrates TabPersistentStoreTest to JUnit4, and uses ChromeBrowserTestRule to ensure we no longer receive crashes related to AccountManagerHelper. Also runs appropriate portions of the tests on the UI thread using ThreadUtils. This is the first of many fixes for several tests that are failing in the same way. BUG= 710901 Review-Url: https://codereview.chromium.org/2929133003 Cr-Commit-Position: refs/heads/master@{#479079} [modify] https://crrev.com/9c9874f171dcdc89467c07d06b5a0d99316cbbad/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java
,
Jul 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4 commit 3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4 Author: thildebr <thildebr@chromium.org> Date: Wed Jul 05 18:08:45 2017 Fix test crashes related to AccountManagerHelper. Moves tests from NativeLibraryTestRule to ChromeBrowserTestRule where appropriate to stop tests from crashing locally with the AccountManagerHelper not initialized error. Also uses RuleChain with UiThreadTestRule to clean up tests that require running on the UI thread, and with the new ClearAppDataRule to ensure app data is cleared before initializing the browser process, fixing various flaky tests. BUG= 710901 Review-Url: https://codereview.chromium.org/2954393003 Cr-Commit-Position: refs/heads/master@{#484308} [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/java_sources.gni [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/IntentHandlerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/TabStateTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/WarmupManagerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/accessibility/FontSizePrefsTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkBridgeTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/bookmarks/BookmarkModelTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/download/OMADownloadHandlerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/DownloadHistoryAdapterTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandlerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/feedback/ConnectivityCheckerTestRule.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/invalidation/InvalidationServiceTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/OmniboxUrlEmphasizerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/omnibox/VoiceSuggestionProviderTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestContactDetailsSectionUnitTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheLauncherTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/precache/PrecacheUMATest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/PreferencesTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/datareduction/DataReductionPromoUtilsTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferencesTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerNativeTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/preferences/website/WebsiteAddressTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandlerTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/share/ShareUrlTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/sync/ui/PassphraseActivityTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/DocumentModeAssassinTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorObserverTestRule.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabModelObserverTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorTabObserverTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/tabmodel/TabPersistentStoreTest.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/test/ChromeBrowserTestRule.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/test/ClearAppDataTestRule.java [add] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/test/CommandLineInitRule.java [modify] https://crrev.com/3c5f49bcc2f5a51c0272ad33bfb38edf10f24fa4/chrome/android/javatests/src/org/chromium/chrome/browser/widget/RoundedIconGeneratorTest.java
,
Jul 5 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by donnd@chromium.org
, Apr 12 2017Labels: -undefined OS-Android Pri-0 Type-Bug-Regression