Cronet RequestFinishedListener called before onSucceeded |
||
Issue descriptionThis causes problems when embedders want to collect some of their own data in annotations.
,
May 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d3b9f7cbcf8d2b9b88364ba361935e4de535b42 commit 5d3b9f7cbcf8d2b9b88364ba361935e4de535b42 Author: xunjieli <xunjieli@chromium.org> Date: Wed May 03 00:00:52 2017 [Cronet] Make metrics reporting happen after terminal callbacks. This CL re-arranges metrics report to happen after terminal callbacks (UrlRequest.onSucceeded, onCanceled, onFailed). This CL adds additional tests to check that RequestFinishedInfo callback is strictly after UrlRequest's terminal callbacks. This CL also fixes a bug where if we get an exception from embedder (onCallbackException), we did not set RequestFinishedReason to FAILED. testOrderFailedRequestJava is a regression test. BUG= 710877 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2844803002 Cr-Commit-Position: refs/heads/master@{#468826} [modify] https://crrev.com/5d3b9f7cbcf8d2b9b88364ba361935e4de535b42/components/cronet/android/cronet_url_request_adapter.cc [modify] https://crrev.com/5d3b9f7cbcf8d2b9b88364ba361935e4de535b42/components/cronet/android/cronet_url_request_adapter.h [modify] https://crrev.com/5d3b9f7cbcf8d2b9b88364ba361935e4de535b42/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java [modify] https://crrev.com/5d3b9f7cbcf8d2b9b88364ba361935e4de535b42/components/cronet/android/test/javatests/src/org/chromium/net/RequestFinishedInfoTest.java
,
May 3 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mge...@chromium.org
, Apr 12 2017Labels: -Pri-3 Pri-1