Ensure that all website settings are deletable |
||
Issue descriptionWebsite settings are becoming more popular for storing origin-scoped data. Programatically ensure that all website settings that support user exceptions are deletable from BrowsingDataRemover (typically as a part of HISTORY or SITE_DATA datatypes).
,
Jul 24 2017
,
Jul 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/195e8042743c1735341294547385c38898fa892f commit 195e8042743c1735341294547385c38898fa892f Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Jul 27 10:52:39 2017 Detect WebsiteSettings that are not deletable Create a value for every WebsiteSetting and call the BrowsingDataRemover. Afterwards check that all values have been deleted. Bug: 710873 Change-Id: I603e70570a80dc1e0a2ffcdb8683fe6b896b31cf Reviewed-on: https://chromium-review.googlesource.com/584876 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#489894} [modify] https://crrev.com/195e8042743c1735341294547385c38898fa892f/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
,
Jul 27 2017
Writing the test showed that the following settings are not properly deleted when CBD is executed: // No one ever seems to write to this content setting? Can it be removed? CONTENT_SETTINGS_TYPE_CLIENT_HINTS // Not deleted but should be deleted with history? CONTENT_SETTINGS_TYPE_IMPORTANT_SITE_INFO // Deprecated and should be removed after M60. CONTENT_SETTINGS_TYPE_PROMPT_NO_DECISION_COUNT // Is cleared in PasswordProtectionService::CleanUpExpiredVerdicts() // but not when CBD is executed. CONTENT_SETTINGS_TYPE_PASSWORD_PROTECTION This bug tracks that all of them are properly handled. IMPORTANT_SITE_INFO should observer history deletions and PASSWORD_PROTECTION should be deleted with history or cache.
,
Jul 27 2017
CLIENT_HINTS is still being implemented: crbug.com/735518
,
Aug 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e7f166d2f4bd084d12d3ef907b2bf2fdfe281d2 commit 0e7f166d2f4bd084d12d3ef907b2bf2fdfe281d2 Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Aug 31 11:08:44 2017 Enable client_hints test Client hints are now deleted with cookies, so they can be added to the website_settings test. Bug: 710873 Change-Id: Ifd432d221182b43fdb5f1c71358cf2e45e0b75a2 Reviewed-on: https://chromium-review.googlesource.com/645090 Reviewed-by: Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#498814} [modify] https://crrev.com/0e7f166d2f4bd084d12d3ef907b2bf2fdfe281d2/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
,
Jan 22 2018
CONTENT_SETTINGS_TYPE_PROMPT_NO_DECISION_COUNT was removed. Only CONTENT_SETTINGS_TYPE_IMPORTANT_SITE_INFO and CONTENT_SETTINGS_TYPE_PASSWORD_PROTECTION left.
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b commit 67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b Author: Christian Dullweber <dullweber@chromium.org> Date: Thu Jun 07 17:21:54 2018 Fix content settings test Deletion of CONTENT_SETTINGS_TYPE_PASSWORD_PROTECTION wasn't covered by ChromeBrowsingDataRemoverDelegate::AllTypesAreGettingDeleted yet. This is fixed by creating a PasswordProtectionService during the test and removing the type from the whitelist. Bug: 710873 Change-Id: I4b2dd8ffd0eb2996f89e616b3c94626fc04b3982 Reviewed-on: https://chromium-review.googlesource.com/1069090 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#565316} [modify] https://crrev.com/67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc [modify] https://crrev.com/67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b/components/content_settings/core/browser/website_settings_registry.cc [modify] https://crrev.com/67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b/components/safe_browsing/password_protection/mock_password_protection_service.cc [modify] https://crrev.com/67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b/components/safe_browsing/password_protection/mock_password_protection_service.h [modify] https://crrev.com/67fdb4f1eea4ed1a252b89aacba6f4c48f9c228b/components/safe_browsing/password_protection/password_protection_service_unittest.cc
,
Dec 10
Can this be closed now?
,
Dec 11
CONTENT_SETTINGS_TYPE_IMPORTANT_SITE_INFO is still missing and I have no idea how that one can be fixed :( |
||
►
Sign in to add a comment |
||
Comment 1 by msramek@chromium.org
, Jul 6 2017