New issue
Advanced search Search tips

Issue 710864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: ----



Sign in to add a comment

webkit_tests timing out on editing/execCommand/delete-non-editable-range-crash.html on chromium.webkit/WebKit Win7 (dbg)

Project Member Reported by jdoerrie@chromium.org, Apr 12 2017

Issue description

webkit_tests timing out on editing/execCommand/delete-non-editable-range-crash.html on chromium.webkit/WebKit Win7 (dbg)

Test editing/execCommand/delete-non-editable-range-crash.html timed out for the first time in build #9480, then consistently starting from build #9483.

Culprit is not clear, assigning to Blink to triage.

(Uninteresting) log output:

19:23:47.061 2132 [20076/54539] editing/execCommand/delete-non-editable-range-crash.html failed unexpectedly (test timed out)
19:23:47.060 3352 worker/5 killing primary driver
19:23:47.061 3352 worker/5 killing secondary driver
19:23:47.061 3352 worker/5 editing/execCommand/delete-non-editable-range-crash.html failed:
19:23:47.061 3352 worker/5  test timed out

Builder:  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29

 
Labels: -Sheriff-Chromium Pri-3
Owner: le...@chromium.org
This is slow on all Debug builds, Windows especially: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=editing%2FexecCommand%2Fdelete-non-editable-range-crash.html

Marking as slow in http://crrev.com/2808273007.

leviw@, do you mind taking a look at this?
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef481283f456d4667e01a8a765f20ad32ffc3f0a

commit ef481283f456d4667e01a8a765f20ad32ffc3f0a
Author: jdoerrie <jdoerrie@chromium.org>
Date: Thu Apr 13 15:21:22 2017

Mark delete-non-editable-range-crash.html as slow

TBR=jdoerrie@chromium.org
BUG= 710864 

Review-Url: https://codereview.chromium.org/2808273007
Cr-Commit-Position: refs/heads/master@{#464410}

[modify] https://crrev.com/ef481283f456d4667e01a8a765f20ad32ffc3f0a/third_party/WebKit/LayoutTests/SlowTests

Components: -Blink Blink>Editing
Owner: ----
Status: Untriaged (was: Available)
Re-routing to editing team for triage.
Owner: xiaoche...@chromium.org
Status: Started (was: Untriaged)
Let me see if rewriting the test helps.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e058730765c6e22261750811bd6587ea4ec1ac37

commit e058730765c6e22261750811bd6587ea4ec1ac37
Author: xiaochengh <xiaochengh@chromium.org>
Date: Mon Apr 17 06:36:15 2017

Reform editing/execCommand/delete-non-editable-range-crash.html

This patch:
1. Simplifies the above mentioned layout test to make it readable
2. Convert it with assert_selection to promote w3c test harness
3. Marks the C++ code that this test reaches, so that the purpose of
the test becomes clear

BUG=679977,  710864 

Review-Url: https://codereview.chromium.org/2824633002
Cr-Commit-Position: refs/heads/master@{#464899}

[delete] https://crrev.com/1c4480e43a3a1592fcd6f8bd6049580932a1a2c8/third_party/WebKit/LayoutTests/editing/execCommand/delete-non-editable-range-crash-expected.txt
[modify] https://crrev.com/e058730765c6e22261750811bd6587ea4ec1ac37/third_party/WebKit/LayoutTests/editing/execCommand/delete-non-editable-range-crash.html
[modify] https://crrev.com/e058730765c6e22261750811bd6587ea4ec1ac37/third_party/WebKit/Source/core/editing/commands/DeleteSelectionCommand.cpp

Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c3a5b71c7bf345605af3c613d9c1bed7d4f84f5

commit 7c3a5b71c7bf345605af3c613d9c1bed7d4f84f5
Author: xiaochengh <xiaochengh@chromium.org>
Date: Tue Apr 18 03:52:09 2017

Revert of Mark delete-non-editable-range-crash.html as slow (patchset #1 id:1 of https://codereview.chromium.org/2808273007/ )

Reason for revert:
The test is no longer slow:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=editing%2FexecCommand%2Fdelete-non-editable-range-crash.html

Original issue's description:
> Mark delete-non-editable-range-crash.html as slow
>
> TBR=jdoerrie@chromium.org
> BUG= 710864 
>
> Review-Url: https://codereview.chromium.org/2808273007
> Cr-Commit-Position: refs/heads/master@{#464410}
> Committed: https://chromium.googlesource.com/chromium/src/+/ef481283f456d4667e01a8a765f20ad32ffc3f0a

TBR=jdoerrie@chromium.org,jdoerrie@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 710864 

Review-Url: https://codereview.chromium.org/2820273002
Cr-Commit-Position: refs/heads/master@{#465130}

[modify] https://crrev.com/7c3a5b71c7bf345605af3c613d9c1bed7d4f84f5/third_party/WebKit/LayoutTests/SlowTests

Sign in to add a comment