New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 710850 link

Starred by 1 user
Status: Fixed
Owner:
loonyb...@chromium.org
Closed: Apr 2017
Cc:
█ binlu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Move "vibrate" feature in to Feature Policy Experimental Features

Project Member Reported by iclell...@chromium.org, Apr 12 2017 
We're moving vibrate out of the V1 MVP; we should move all instances of it behind the featurePolicyExperimentalFeatures flag.

This was already partially done in https://crrev.com/a2d89c5a6f, but to finish it up, we should also move the parsing code in third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp behind that flag as well, so that the feature name is not recognized in iframe allow attribute values.

Comment 1 by lunalu@chromium.org, Apr 12 2017 

Yes. I realized that just yesterday. I included that part in my last CL for allow attribute clean up.

But I can certainly separate that part out for a smaller CL.

Comment 2 by lunalu@chromium.org, Apr 12 2017

Cc: binlu@chromium.org
Also I should have moved the virtual tests under another directory. This causes other CL's (e.g., https://codereview.chromium.org/2778693004/) to fail.

Fixing it asap.

Comment 3 by lunalu@chromium.org, Apr 13 2017 

I think vibrate tests are being disabled in Bin's CL. Depends on which CL lands first. I will have to reenable the tests after my fix (https://codereview.chromium.org/2814153002/)
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2

commit db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2
Author: lunalu <lunalu@chromium.org>
Date: Mon Apr 24 15:53:24 2017

Move feature policy vibrate tests to correct directory

vibrate is not behind the flag FeaturePolicyExpeirmentalFeatures, so
move the virtual tests to feature-policy-experiment-features/ from
feature-policy/

BUG= 710850 

Review-Url: https://codereview.chromium.org/2814153002
Cr-Commit-Position: refs/heads/master@{#466634}

[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/content/browser/site_per_process_browsertest.cc
[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/VirtualTestSuites
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/resources/feature-policy-vibrate-disabled.html
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/resources/feature-policy-vibrate-enabled.html
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-disabled-expected.txt
[copy] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-disabled.php
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-enabledforall.php
[copy] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-enabledforself-expected.txt
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/http/tests/feature-policy-experimental-features/vibrate-enabledforself.php
[delete] https://crrev.com/91522d0519823a43060738914a65b71119b669d7/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-disabled.php
[delete] https://crrev.com/91522d0519823a43060738914a65b71119b669d7/third_party/WebKit/LayoutTests/http/tests/feature-policy/vibrate-enabledforall-expected.txt
[add] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/http/tests/feature-policy-experimental-features/README.txt
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/http/tests/feature-policy-experimental-features/vibrate-disabled-expected.txt
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/http/tests/feature-policy-experimental-features/vibrate-enabledforself-expected.txt
[rename] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/LayoutTests/virtual/feature-policy-experimental-features/http/tests/feature-policy-experimental-features/vibrate_in_cross_origin_iframe_blocked-expected.txt
[delete] https://crrev.com/91522d0519823a43060738914a65b71119b669d7/third_party/WebKit/LayoutTests/virtual/feature-policy/http/tests/feature-policy/vibrate-enabledforall-expected.txt
[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp
[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h
[modify] https://crrev.com/db0b96ce2d50d57a55f6f5c44aeb30d3dbb9e5d2/third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp

Comment 5 by lunalu@chromium.org, Apr 24 2017

Status: Fixed (was: Assigned)

Comment 6 by rbyers@chromium.org, Jul 18 2017

Owner: loonyb...@chromium.org
►

Sign in to add a comment